Message ID | 1391453028-23191-2-git-send-email-Liviu.Dudau@arm.com |
---|---|
State | New |
Headers | show |
On Mon, Feb 03, 2014 at 06:58:56PM +0000, Arnd Bergmann wrote: > On Monday 03 February 2014 18:43:48 Liviu Dudau wrote: > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > > index 4cc813e..ce5bad2 100644 > > --- a/arch/arm64/include/asm/io.h > > +++ b/arch/arm64/include/asm/io.h > > @@ -120,9 +120,13 @@ static inline u64 __raw_readq(const volatile void __iomem *addr) > > /* > > * I/O port access primitives. > > */ > > +#define arch_has_dev_port() (0) > > Why not? Maybe I got it the wrong way around, but the comment in include/linux/io.h says: /* * Some systems do not have legacy ISA devices. * /dev/port is not a valid interface on these systems. * So for those archs, <asm/io.h> should define the following symbol. */ So ... defining it should mean no legacy ISA devices, right? > > > #define IO_SPACE_LIMIT 0xffff > > You probably want to increase this a bit, to allow multiple host bridges > to have their own I/O space. OK, but to what size? > > > #define PCI_IOBASE ((void __iomem *)(MODULES_VADDR - SZ_2M)) > > And modify this location: There is no particular reason to have the I/O space > mapped exactly 2MB below the loadable modules, as virtual address space is > essentially free. Will talk with Catalin about where to place this. > > > +#define ioport_map(port, nr) (PCI_IOBASE + ((port) & IO_SPACE_LIMIT)) > > +#define ioport_unmap(addr) > > inline functions? Will do, thanks! > > > static inline u8 inb(unsigned long addr) > > { > > return readb(addr + PCI_IOBASE); > > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h > > new file mode 100644 > > index 0000000..dd084a3 > > --- /dev/null > > +++ b/arch/arm64/include/asm/pci.h > > @@ -0,0 +1,35 @@ > > +#ifndef __ASM_PCI_H > > +#define __ASM_PCI_H > > +#ifdef __KERNEL__ > > + > > +#include <linux/types.h> > > +#include <linux/slab.h> > > +#include <linux/dma-mapping.h> > > + > > +#include <asm/io.h> > > +#include <asm-generic/pci-bridge.h> > > +#include <asm-generic/pci-dma-compat.h> > > + > > +#define PCIBIOS_MIN_IO 0 > > +#define PCIBIOS_MIN_MEM 0 > > PCIBIOS_MIN_IO is normally set to 0x1000, to stay out of the ISA range. :) No ISA support! (Die ISA, die!!) > > > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c > > new file mode 100644 > > index 0000000..7b652cf > > --- /dev/null > > +++ b/arch/arm64/kernel/pci.c > > @@ -0,0 +1,112 @@ > > None of this looks really arm64 specific, nor should it be. I think > we should try a little harder to move this as a default implementation > into common code, even if we start out by having all architectures > override it. Agree. This is the RFC version. I didn't dare to post a patch with fixes for all architectures. :) > > > +int pci_ioremap_io(unsigned int offset, phys_addr_t phys_addr) > > +{ > > + BUG_ON(offset + SZ_64K - 1 > IO_SPACE_LIMIT); > > + > > + return ioremap_page_range((unsigned long)PCI_IOBASE + offset, > > + (unsigned long)PCI_IOBASE + offset + SZ_64K, > > + phys_addr, > > + __pgprot(PROT_DEVICE_nGnRE)); > > +} > > Not sure if we want to treat this one as architecture specific though. > It certainly won't be portable to x86, but it could be shared with > a couple of others. We may also want to redesign the interface. > I've been thinking we could make this function allocate space in the > Linux virtual I/O space aperture, and pass two resources into it > (physical I/O aperture and bus I/O range), and get the actual > io_offset as the return value, or a negative error number. Not sure I completely follow your idea. > > That way, you could have an arbitrary number of host bridges in the > system and each one gets a share of the virtual aperture until > it's full. One still needs to fix the pci_request_region use that checks against ioport_resource. But it is an interesting idea. > > Arnd > > Thanks for reviewing this patch! Liviu
On Mon, Feb 03, 2014 at 10:34:40PM +0000, Andrew Murray wrote: > On 3 February 2014 18:43, Liviu Dudau <Liviu.Dudau@arm.com> wrote: > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > > index 4cc813e..ce5bad2 100644 > > --- a/arch/arm64/include/asm/io.h > > +++ b/arch/arm64/include/asm/io.h > > @@ -120,9 +120,13 @@ static inline u64 __raw_readq(const volatile void __iomem *addr) > > /* > > * I/O port access primitives. > > */ > > +#define arch_has_dev_port() (0) > > #define IO_SPACE_LIMIT 0xffff > > #define PCI_IOBASE ((void __iomem *)(MODULES_VADDR - SZ_2M)) > > > > +#define ioport_map(port, nr) (PCI_IOBASE + ((port) & IO_SPACE_LIMIT)) > > +#define ioport_unmap(addr) > > I'm not sure that this will work. The in[bwl], out[bwl] macros in > arch/arm64/include/asm/io.h already add the PCI_IOBASE offset. > > Instead of these two #defines, why not just enforce that > GENERIC_PCI_IOMAP is enabled? Or at least wrap these defines with 'if > (!config_enabled(CONFIG_GENERIC_PCI_IOMAP))' or similar. GENERIC_PCI_IOMAP *is* enabled for AArch64. We have select GENERIC_IOMAP in arch/arm64/Kconfig which in turn selects GENERIC_PCI_IOMAP in lib/Kconfig. Best regards, Liviu > > > + > > static inline u8 inb(unsigned long addr) > > { > > return readb(addr + PCI_IOBASE); > > > Andrew Murray >
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index f8e5ee6..48fdd69 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -133,6 +133,23 @@ menu "Bus support" config ARM_AMBA bool +config PCI + bool "PCI support" + help + This feature enables support for PCIe bus system. If you say Y + here, the kernel will include drivers and infrastructure code + to support PCIe bus devices. + +config PCI_DOMAINS + def_bool PCI + +config PCI_SYSCALL + def_bool PCI + +source "drivers/pci/Kconfig" +source "drivers/pci/pcie/Kconfig" +source "drivers/pci/hotplug/Kconfig" + endmenu menu "Kernel Features" diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild index 71c53ec..46924bc 100644 --- a/arch/arm64/include/asm/Kbuild +++ b/arch/arm64/include/asm/Kbuild @@ -26,6 +26,7 @@ generic-y += mman.h generic-y += msgbuf.h generic-y += mutex.h generic-y += pci.h +generic-y += pci-bridge.h generic-y += poll.h generic-y += posix_types.h generic-y += resource.h diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h index 4cc813e..ce5bad2 100644 --- a/arch/arm64/include/asm/io.h +++ b/arch/arm64/include/asm/io.h @@ -120,9 +120,13 @@ static inline u64 __raw_readq(const volatile void __iomem *addr) /* * I/O port access primitives. */ +#define arch_has_dev_port() (0) #define IO_SPACE_LIMIT 0xffff #define PCI_IOBASE ((void __iomem *)(MODULES_VADDR - SZ_2M)) +#define ioport_map(port, nr) (PCI_IOBASE + ((port) & IO_SPACE_LIMIT)) +#define ioport_unmap(addr) + static inline u8 inb(unsigned long addr) { return readb(addr + PCI_IOBASE); diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h new file mode 100644 index 0000000..dd084a3 --- /dev/null +++ b/arch/arm64/include/asm/pci.h @@ -0,0 +1,35 @@ +#ifndef __ASM_PCI_H +#define __ASM_PCI_H +#ifdef __KERNEL__ + +#include <linux/types.h> +#include <linux/slab.h> +#include <linux/dma-mapping.h> + +#include <asm/io.h> +#include <asm-generic/pci-bridge.h> +#include <asm-generic/pci-dma-compat.h> + +#define PCIBIOS_MIN_IO 0 +#define PCIBIOS_MIN_MEM 0 + +/* + * Set to 1 if the kernel should re-assign all PCI bus numbers + */ +#define pcibios_assign_all_busses() \ + (pci_has_flag(PCI_REASSIGN_ALL_BUS)) + +/* + * PCI address space differs from physical memory address space + */ +#define PCI_DMA_BUS_IS_PHYS (0) + +extern int isa_dma_bridge_buggy; + +extern int pci_domain_nr(struct pci_bus *bus); +extern int pci_proc_domain(struct pci_bus *bus); + +extern int pci_ioremap_io(unsigned int offset, phys_addr_t phys_addr); + +#endif /* __KERNEL__ */ +#endif /* __ASM_PCI_H */ diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile index 2d7fcc1..8cfec47 100644 --- a/arch/arm64/kernel/Makefile +++ b/arch/arm64/kernel/Makefile @@ -21,6 +21,7 @@ arm64-obj-$(CONFIG_EARLY_PRINTK) += early_printk.o arm64-obj-$(CONFIG_ARM64_CPU_SUSPEND) += sleep.o suspend.o arm64-obj-$(CONFIG_JUMP_LABEL) += jump_label.o arm64-obj-$(CONFIG_SCHED_HMP) += sched_hmp.o +arm64-obj-$(CONFIG_PCI) += pci.o obj-y += $(arm64-obj-y) vdso/ obj-m += $(arm64-obj-m) diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c new file mode 100644 index 0000000..7b652cf --- /dev/null +++ b/arch/arm64/kernel/pci.c @@ -0,0 +1,112 @@ +/* + * Code borrowed from powerpc/kernel/pci-common.c + * + * Copyright (C) 2003 Anton Blanchard <anton@au.ibm.com>, IBM + * Copyright (C) 2014 ARM Ltd. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + */ + +#include <linux/init.h> +#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/mm.h> +#include <linux/of_pci.h> +#include <linux/of_platform.h> +#include <linux/slab.h> + +#include <asm/pci-bridge.h> + + +/* + * Return the domain number for this bus + */ +int pci_domain_nr(struct pci_bus *bus) +{ + struct pci_host_bridge *bridge = to_pci_host_bridge(bus->bridge); + + if (bridge) + return bridge->domain_nr; + + return 0; +} + +int pci_proc_domain(struct pci_bus *bus) +{ + return pci_domain_nr(bus); +} + +/* + * Called after each bus is probed, but before its children are examined + */ +void pcibios_fixup_bus(struct pci_bus *bus) +{ + struct pci_dev *dev; + struct resource *res; + int i; + + if (bus->self != NULL) { + pci_read_bridge_bases(bus); + + pci_bus_for_each_resource(bus, res, i) { + if (!res || !res->flags || res->parent) + continue; + + /* + * If we are going to reassign everything, we can + * shrink the P2P resource to have zero size to + * save space + */ + if (pci_has_flag(PCI_REASSIGN_ALL_RSRC)) { + res->flags |= IORESOURCE_UNSET; + res->start = 0; + res->end = -1; + continue; + } + } + } + + list_for_each_entry(dev, &bus->devices, bus_list) { + /* Ignore fully discovered devices */ + if (dev->is_added) + continue; + + set_dev_node(&dev->dev, pcibus_to_node(dev->bus)); + + /* Read default IRQs and fixup if necessary */ + dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); + } +} +EXPORT_SYMBOL(pcibios_fixup_bus); + +/* + * We don't have to worry about legacy ISA devices, so nothing to do here + */ +resource_size_t pcibios_align_resource(void *data, const struct resource *res, + resource_size_t size, resource_size_t align) +{ + return ALIGN(res->start, align); +} +EXPORT_SYMBOL(pcibios_align_resource); + +int pcibios_enable_device(struct pci_dev *dev, int mask) +{ + return pci_enable_resources(dev, mask); +} + +void pcibios_fixup_bridge_ranges(struct list_head *resources) +{ +} + +int pci_ioremap_io(unsigned int offset, phys_addr_t phys_addr) +{ + BUG_ON(offset + SZ_64K - 1 > IO_SPACE_LIMIT); + + return ioremap_page_range((unsigned long)PCI_IOBASE + offset, + (unsigned long)PCI_IOBASE + offset + SZ_64K, + phys_addr, + __pgprot(PROT_DEVICE_nGnRE)); +}
Use the generic host bridge functions to provide support for PCI Express on arm64. There is no support for ISA memory. Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> --- arch/arm64/Kconfig | 17 +++++++ arch/arm64/include/asm/Kbuild | 1 + arch/arm64/include/asm/io.h | 4 ++ arch/arm64/include/asm/pci.h | 35 +++++++++++++ arch/arm64/kernel/Makefile | 1 + arch/arm64/kernel/pci.c | 112 ++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 170 insertions(+) create mode 100644 arch/arm64/include/asm/pci.h create mode 100644 arch/arm64/kernel/pci.c