diff mbox series

[1/1] efi_loader: NULL dereference in efi_convert_pointer

Message ID 20200707014636.53422-1-xypron.glpk@gmx.de
State Accepted
Commit a27c78fddbbafcace558368a92f9b9fdaeee8b5c
Headers show
Series [1/1] efi_loader: NULL dereference in efi_convert_pointer | expand

Commit Message

Heinrich Schuchardt July 7, 2020, 1:46 a.m. UTC 
Avoid a possible NULL pointer dereference in efi_convert_pointer().

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
 lib/efi_loader/efi_runtime.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--
2.27.0
diff mbox series

Patch

diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c
index c0bd99b867..121e2f65c6 100644
--- a/lib/efi_loader/efi_runtime.c
+++ b/lib/efi_loader/efi_runtime.c
@@ -499,7 +499,7 @@  static __efi_runtime efi_status_t EFIAPI efi_convert_pointer_runtime(
 static __efi_runtime efi_status_t EFIAPI efi_convert_pointer(
 			efi_uintn_t debug_disposition, void **address)
 {
-	efi_physical_addr_t addr = (uintptr_t)*address;
+	efi_physical_addr_t addr;
 	efi_uintn_t i;
 	efi_status_t ret = EFI_NOT_FOUND;

@@ -515,6 +515,7 @@  static __efi_runtime efi_status_t EFIAPI efi_convert_pointer(
 		goto out;
 	}

+	addr = (uintptr_t)*address;
 	for (i = 0; i < efi_descriptor_count; i++) {
 		struct efi_mem_desc *map = (void *)efi_virtmap +
 					   (efi_descriptor_size * i);