| Message ID | 1392137369-20277-1-git-send-email-ian.campbell@citrix.com |
|---|---|
| State | New |
| Headers | show |
On Tue, 2014-02-11 at 17:08 +0000, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST] cs-adjust-flight: fix runvar-del"): > > Missing $. > > WTF I assume this isn't used much :-) > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Thanks. > Maybe we should have a "non-urgent pending fixes" branch, since our > push gate is going to be busy for a while. Sure. Will you create it?
On Tue, 2014-02-11 at 17:08 +0000, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST] cs-adjust-flight: fix runvar-del"): > > Missing $. > > WTF > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> > > Maybe we should have a "non-urgent pending fixes" branch, since our > push gate is going to be busy for a while. You created and eventually merged such a branch but I don't think this was in it... Ian.
Ian Campbell writes ("Re: [PATCH OSSTEST] cs-adjust-flight: fix runvar-del"):
> On Tue, 2014-02-11 at 17:08 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH OSSTEST] cs-adjust-flight: fix runvar-del"):
> > > Missing $.
> >
> > WTF
> >
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> >
> > Maybe we should have a "non-urgent pending fixes" branch, since our
> > push gate is going to be busy for a while.
>
> You created and eventually merged such a branch but I don't think this
> was in it...
I think you're right. Please push it.
Ian.
diff --git a/cs-adjust-flight b/cs-adjust-flight index d937caa..663ca6f 100755 --- a/cs-adjust-flight +++ b/cs-adjust-flight @@ -228,7 +228,7 @@ sub change__runvar_del { for_runvars($jobs, $vars, sub { my ($job, $name) = @_; - runvar_rm_q->execute($dstflight, $job, $name); + $runvar_rm_q->execute($dstflight, $job, $name); verbose "$dstflight.$job $name runvar deleted\n"; }, 'IGNORE'); }
Missing $. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- cs-adjust-flight | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)