diff mbox series

lib: rsa: Also check for presence of r-squared property

Message ID 4d07c3f1-25b9-50c5-ce43-a4402e560afe@siemens.com
State Accepted
Commit 48069ff84fe5e5e0ad733bef4718e02600b518c4
Headers show
Series lib: rsa: Also check for presence of r-squared property | expand

Commit Message

Jan Kiszka May 7, 2020, 6:36 p.m. UTC 
From: Jan Kiszka <jan.kiszka at siemens.com>

Better than crashing later if it is missing.

Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
---
 lib/rsa/rsa-verify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini May 15, 2020, 8:53 p.m. UTC | #1 
On Thu, May 07, 2020 at 08:36:13PM +0200, Jan Kiszka wrote:

> From: Jan Kiszka <jan.kiszka at siemens.com>
> 
> Better than crashing later if it is missing.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c
index 80e817314b..f7ae174cb0 100644
--- a/lib/rsa/rsa-verify.c
+++ b/lib/rsa/rsa-verify.c
@@ -445,7 +445,7 @@  static int rsa_verify_with_keynode(struct image_sign_info *info,
 
 	prop.rr = fdt_getprop(blob, node, "rsa,r-squared", NULL);
 
-	if (!prop.num_bits || !prop.modulus) {
+	if (!prop.num_bits || !prop.modulus || !prop.rr) {
 		debug("%s: Missing RSA key info", __func__);
 		return -EFAULT;
 	}