diff mbox series

cmd: efidebug: add a comment against Coverity check (300329)

Message ID 20200508055018.7403-1-takahiro.akashi@linaro.org
State Accepted
Commit e2a5b8603087bc3f8f9acd4cc171df48e7ef0a6a
Headers show
Series cmd: efidebug: add a comment against Coverity check (300329) | expand

Commit Message

AKASHI Takahiro May 8, 2020, 5:50 a.m. UTC 
The check here, "Null pointer dereferences," is a false positive.
So leave a comment.

Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
Reported-by: Coverity (CID 300329)
---
 cmd/efidebug.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series

Patch

diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index 9769aeeac58b..70aba446a937 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -481,6 +481,11 @@  static int do_efi_show_memmap(cmd_tbl_t *cmdtp, int flag,
 	       EFI_PHYS_ADDR_WIDTH - 5, spc, EFI_PHYS_ADDR_WIDTH - 3, spc);
 	printf("================ %.*s %.*s ==========\n",
 	       EFI_PHYS_ADDR_WIDTH, sep, EFI_PHYS_ADDR_WIDTH, sep);
+	/*
+	 * Coverity check: dereferencing null pointer "map."
+	 * This is a false positive as memmap will always be
+	 * populated by allocate_pool() above.
+	 */
 	for (i = 0, map = memmap; i < map_size / sizeof(*map); map++, i++) {
 		if (map->type < EFI_MAX_MEMORY_TYPE)
 			type = efi_mem_type_string[map->type];