diff mbox series

[1/1] video: backlight: cr_bllcd: Remove unused variable 'intensity'

Message ID 20200721073919.925935-1-lee.jones@linaro.org
State New
Headers show
Series [1/1] video: backlight: cr_bllcd: Remove unused variable 'intensity' | expand

Commit Message

Lee Jones July 21, 2020, 7:39 a.m. UTC 
Fixes the following kernel build warning:

 drivers/video/backlight/cr_bllcd.c: In function ‘cr_backlight_set_intensity’:
 drivers/video/backlight/cr_bllcd.c:62:6: warning: unused variable ‘intensity’ [-Wunused-variable]
 62 | int intensity = bd->props.brightness;
 | ^~~~~~~~~

Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Fixes: 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight semantics")
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/video/backlight/cr_bllcd.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.25.1

Comments

Daniel Thompson July 21, 2020, 1:52 p.m. UTC | #1 
On Tue, Jul 21, 2020 at 08:39:19AM +0100, Lee Jones wrote:
> Fixes the following kernel build warning:

> 

>  drivers/video/backlight/cr_bllcd.c: In function ‘cr_backlight_set_intensity’:

>  drivers/video/backlight/cr_bllcd.c:62:6: warning: unused variable ‘intensity’ [-Wunused-variable]

>  62 | int intensity = bd->props.brightness;

>  | ^~~~~~~~~

> 

> Cc: Sam Ravnborg <sam@ravnborg.org>

> Cc: Daniel Thompson <daniel.thompson@linaro.org>

> Cc: Jingoo Han <jingoohan1@gmail.com>

> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

> Cc: dri-devel@lists.freedesktop.org

> Cc: linux-fbdev@vger.kernel.org

> Fixes: 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight semantics")

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


I doubt you are awaiting this for a one line fixup... but just in case:

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>



Daniel.
diff mbox series

Patch

diff --git a/drivers/video/backlight/cr_bllcd.c b/drivers/video/backlight/cr_bllcd.c
index a24d42e1ea3cd..4ad0a72531fe2 100644
--- a/drivers/video/backlight/cr_bllcd.c
+++ b/drivers/video/backlight/cr_bllcd.c
@@ -59,7 +59,6 @@  struct cr_panel {
 
 static int cr_backlight_set_intensity(struct backlight_device *bd)
 {
-	int intensity = bd->props.brightness;
 	u32 addr = gpio_bar + CRVML_PANEL_PORT;
 	u32 cur = inl(addr);