diff mbox series

[V3,2/2] dt-bindings: mailbox: add doorbell support to ARM MHU

Message ID 5d448f579a41345130ae25d01bb94a6e293a6460.1599731645.git.viresh.kumar@linaro.org
State Superseded
Headers show
Series [V3,1/2] dt-bindings: mailbox : arm,mhu: Convert to Json-schema | expand

Commit Message

Viresh Kumar Sept. 10, 2020, 9:55 a.m. UTC 
From: Sudeep Holla <sudeep.holla@arm.com>


The ARM MHU's reference manual states following:

"The MHU drives the signal using a 32-bit register, with all 32 bits
logically ORed together. The MHU provides a set of registers to enable
software to set, clear, and check the status of each of the bits of this
register independently.  The use of 32 bits for each interrupt line
enables software to provide more information about the source of the
interrupt. For example, each bit of the register can be associated with
a type of event that can contribute to raising the interrupt."

This patch thus extends the MHU controller's DT binding to add support
for doorbell mode.

Though the same MHU hardware controller is used in the two modes, A new
compatible string is added here to represent the combination of the MHU
hardware and the firmware sitting on the other side (which expects each
bit to represent a different signal now).

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Co-developed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
V3: Update the json schema and fix number of interrupt lines.

 .../devicetree/bindings/mailbox/arm,mhu.yaml  | 60 +++++++++++++++++--
 1 file changed, 54 insertions(+), 6 deletions(-)

-- 
2.25.0.rc1.19.g042ed3e048af

Comments

Rob Herring Sept. 15, 2020, 7:40 p.m. UTC | #1 
On Thu, 10 Sep 2020 15:25:19 +0530, Viresh Kumar wrote:
> From: Sudeep Holla <sudeep.holla@arm.com>

> 

> The ARM MHU's reference manual states following:

> 

> "The MHU drives the signal using a 32-bit register, with all 32 bits

> logically ORed together. The MHU provides a set of registers to enable

> software to set, clear, and check the status of each of the bits of this

> register independently.  The use of 32 bits for each interrupt line

> enables software to provide more information about the source of the

> interrupt. For example, each bit of the register can be associated with

> a type of event that can contribute to raising the interrupt."

> 

> This patch thus extends the MHU controller's DT binding to add support

> for doorbell mode.

> 

> Though the same MHU hardware controller is used in the two modes, A new

> compatible string is added here to represent the combination of the MHU

> hardware and the firmware sitting on the other side (which expects each

> bit to represent a different signal now).

> 

> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

> Co-developed-by: Viresh Kumar <viresh.kumar@linaro.org>

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---

> V3: Update the json schema and fix number of interrupt lines.

> 

>  .../devicetree/bindings/mailbox/arm,mhu.yaml  | 60 +++++++++++++++++--

>  1 file changed, 54 insertions(+), 6 deletions(-)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
index 4e840cedb2e4..88980ba005a4 100644
--- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
@@ -18,20 +18,40 @@  description: |
   remote clears it after having read the data.  The last channel is specified to
   be a 'Secure' resource, hence can't be used by Linux running NS.
 
+  The MHU hardware also allows operations in doorbell mode. The MHU drives the
+  interrupt signal using a 32-bit register, with all 32-bits logically ORed
+  together. It provides a set of registers to enable software to set, clear and
+  check the status of each of the bits of this register independently. The use
+  of 32 bits per interrupt line enables software to provide more information
+  about the source of the interrupt. For example, each bit of the register can
+  be associated with a type of event that can contribute to raising the
+  interrupt. Each of the 32-bits can be used as "doorbell" to alert the remote
+  processor.
+
 # We need a select here so we don't match all nodes with 'arm,primecell'
 select:
   properties:
     compatible:
       contains:
-        const: arm,mhu
+        enum:
+          - arm,mhu
+          - arm,mhu-doorbell
   required:
     - compatible
 
 properties:
   compatible:
-    items:
-      - const: arm,mhu
-      - const: arm,primecell
+    oneOf:
+      - description: Data transfer mode
+        items:
+          - const: arm,mhu
+          - const: arm,primecell
+
+      - description: Doorbell mode
+        items:
+          - const: arm,mhu-doorbell
+          - const: arm,primecell
+
 
   reg:
     maxItems: 1
@@ -50,8 +70,11 @@  description: |
       - const: apb_pclk
 
   '#mbox-cells':
-    description: Index of the channel.
-    const: 1
+    description: |
+      Set to 1 in data transfer mode and represents index of the channel.
+      Set to 2 in doorbell mode and represents index of the channel and doorbell
+      number.
+    enum: [ 1, 2 ]
 
 required:
   - compatible
@@ -62,6 +85,7 @@  description: |
 additionalProperties: false
 
 examples:
+  # Data transfer mode.
   - |
     soc {
         #address-cells = <2>;
@@ -84,3 +108,27 @@  additionalProperties: false
             mboxes = <&mhuA 1>; /* HP-NonSecure */
         };
     };
+
+  # Doorbell mode.
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        mhuB: mailbox@2b2f0000 {
+            #mbox-cells = <2>;
+            compatible = "arm,mhu-doorbell", "arm,primecell";
+            reg = <0 0x2b2f0000 0 0x1000>;
+            interrupts = <0 36 4>, /* LP-NonSecure */
+                         <0 35 4>, /* HP-NonSecure */
+                         <0 37 4>; /* Secure */
+            clocks = <&clock 0 2 1>;
+            clock-names = "apb_pclk";
+        };
+
+        mhu_client_scpi: scpi@2f000000 {
+            compatible = "arm,scpi";
+            reg = <0 0x2f000000 0 0x200>;
+            mboxes = <&mhuB 1 4>; /* HP-NonSecure, 5th doorbell */
+        };
+    };