| Message ID | 1600674184-3537-2-git-send-email-loic.poulain@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] bus: mhi: Remove auto-start option | expand |
On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote: > Start MHI device channels so that transfers can be performed. > The MHI stack does not auto-start channels anymore. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Dave: I'd like to queue this patch through MHI tree because there is a dependent change in MHI bus. So, can you please provide your Ack? Thanks, Mani > --- > v2: split MHI and qrtr changes in dedicated commits > > net/qrtr/mhi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c > index ff0c414..7100f0b 100644 > --- a/net/qrtr/mhi.c > +++ b/net/qrtr/mhi.c > @@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev, > struct qrtr_mhi_dev *qdev; > int rc; > > + /* start channels */ > + rc = mhi_prepare_for_transfer(mhi_dev); > + if (rc) > + return rc; > + > qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL); > if (!qdev) > return -ENOMEM; > -- > 2.7.4 >
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Date: Sat, 26 Sep 2020 13:26:56 +0530 > On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote: >> Start MHI device channels so that transfers can be performed. >> The MHI stack does not auto-start channels anymore. >> >> Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Dave: I'd like to queue this patch through MHI tree because there is a dependent > change in MHI bus. So, can you please provide your Ack? Sure: Acked-by: David S. Miller <davem@davemloft.net>
On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote: > Start MHI device channels so that transfers can be performed. > The MHI stack does not auto-start channels anymore. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Applied to mhi-next! Thanks, Mani > --- > v2: split MHI and qrtr changes in dedicated commits > > net/qrtr/mhi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c > index ff0c414..7100f0b 100644 > --- a/net/qrtr/mhi.c > +++ b/net/qrtr/mhi.c > @@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev, > struct qrtr_mhi_dev *qdev; > int rc; > > + /* start channels */ > + rc = mhi_prepare_for_transfer(mhi_dev); > + if (rc) > + return rc; > + > qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL); > if (!qdev) > return -ENOMEM; > -- > 2.7.4 >
+ath11k list On Mon, Sep 21, 2020 at 09:43:04AM +0200, Loic Poulain wrote: > Start MHI device channels so that transfers can be performed. > The MHI stack does not auto-start channels anymore. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Applied to mhi-ath11k-immutable branch! This branch will get merged into mhi-next and ath-next. Thanks, Mani > --- > v2: split MHI and qrtr changes in dedicated commits > > net/qrtr/mhi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c > index ff0c414..7100f0b 100644 > --- a/net/qrtr/mhi.c > +++ b/net/qrtr/mhi.c > @@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev, > struct qrtr_mhi_dev *qdev; > int rc; > > + /* start channels */ > + rc = mhi_prepare_for_transfer(mhi_dev); > + if (rc) > + return rc; > + > qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL); > if (!qdev) > return -ENOMEM; > -- > 2.7.4 >
diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c index ff0c414..7100f0b 100644 --- a/net/qrtr/mhi.c +++ b/net/qrtr/mhi.c @@ -76,6 +76,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev, struct qrtr_mhi_dev *qdev; int rc; + /* start channels */ + rc = mhi_prepare_for_transfer(mhi_dev); + if (rc) + return rc; + qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL); if (!qdev) return -ENOMEM;
Start MHI device channels so that transfers can be performed. The MHI stack does not auto-start channels anymore. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- v2: split MHI and qrtr changes in dedicated commits net/qrtr/mhi.c | 5 +++++ 1 file changed, 5 insertions(+)