diff mbox series

[v3,07/10] gpio: mockup: increase the number of supported device properties

Message ID 20200929101004.20288-8-brgl@bgdev.pl
State New
Headers show
Series gpio: mockup: refactoring + documentation | expand

Commit Message

Bartosz Golaszewski Sept. 29, 2020, 10:10 a.m. UTC 
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

The driver actually supports 4 properties but we only ever set up up to
three. This will change however in upcoming patches so increase the
number of really (as in: the number the property array can hold)
supported properties to 4.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/gpio/gpio-mockup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andy Shevchenko Sept. 29, 2020, 10:53 a.m. UTC | #1 
On Tue, Sep 29, 2020 at 12:10:01PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> The driver actually supports 4 properties but we only ever set up up to
> three. This will change however in upcoming patches so increase the
> number of really (as in: the number the property array can hold)
> supported properties to 4.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reported-by ? (it does not imply the necessity of Fixes tag)

> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  drivers/gpio/gpio-mockup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
> index de778b52f355..856ba5da1e8c 100644
> --- a/drivers/gpio/gpio-mockup.c
> +++ b/drivers/gpio/gpio-mockup.c
> @@ -29,8 +29,8 @@
>   * of GPIO lines.
>   */
>  #define GPIO_MOCKUP_MAX_RANGES	(GPIO_MOCKUP_MAX_GC * 2)
> -/* Maximum of three properties + the sentinel. */
> -#define GPIO_MOCKUP_MAX_PROP	4
> +/* Maximum of four properties + the sentinel. */
> +#define GPIO_MOCKUP_MAX_PROP	5
>  
>  /*
>   * struct gpio_pin_status - structure describing a GPIO status
> -- 
> 2.26.1
>
Bartosz Golaszewski Sept. 30, 2020, 8:05 a.m. UTC | #2 
On Tue, Sep 29, 2020 at 12:53 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>

> On Tue, Sep 29, 2020 at 12:10:01PM +0200, Bartosz Golaszewski wrote:

> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

> >

> > The driver actually supports 4 properties but we only ever set up up to

> > three. This will change however in upcoming patches so increase the

> > number of really (as in: the number the property array can hold)

> > supported properties to 4.

>

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

>

> Reported-by ? (it does not imply the necessity of Fixes tag)


I'll add it when applying.

Bartosz
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index de778b52f355..856ba5da1e8c 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -29,8 +29,8 @@ 
  * of GPIO lines.
  */
 #define GPIO_MOCKUP_MAX_RANGES	(GPIO_MOCKUP_MAX_GC * 2)
-/* Maximum of three properties + the sentinel. */
-#define GPIO_MOCKUP_MAX_PROP	4
+/* Maximum of four properties + the sentinel. */
+#define GPIO_MOCKUP_MAX_PROP	5
 
 /*
  * struct gpio_pin_status - structure describing a GPIO status