| Message ID | 20200831161147.13515-1-krzk@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: mfd: google,cros-ec: Use unevaluatedProperties | expand |
On Mon, 31 Aug 2020 at 18:11, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > There might be multiple reset GPIOs but dtschema has trouble parsing it > if there are no maxItems: > > arch/arm/boot/dts/exynos5250-snow.dt.yaml: mmc3_pwrseq: reset-gpios: [[20, 2, 1], [20, 1, 1]] is too long > From schema: Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > index 449215444723..8d625f903856 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > @@ -20,6 +20,8 @@ properties: > > reset-gpios: > minItems: 1 > + # Put some limit to avoid false warnings > + maxItems: 32 Not sure what number to pick. I guess two should be enough, but on the other hand it doesn't really matter. > description: > contains a list of GPIO specifiers. The reset GPIOs are asserted > at initialization and prior we start the power up procedure of the card. > -- > 2.17.1 > Applied for next, thanks! Kind regards Uffe
On Mon, Aug 31, 2020 at 06:11:46PM +0200, Krzysztof Kozlowski wrote: > Additional properties or nodes actually might appear (e.g. wakeup) so > use unevaluatedProperties to fix dtbs_check warnings like: > > arch/arm/boot/dts/exynos5250-snow.dt.yaml: embedded-controller@1e: > 'keyboard-controller', 'wakeup-source' do not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index 6a7279a85ec1..0586c5791cf6 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -79,7 +79,7 @@ then: google,cros-ec-spi-msg-delay: false spi-max-frequency: false -additionalProperties: false +unevaluatedProperties: false examples: # Example for I2C
Additional properties or nodes actually might appear (e.g. wakeup) so use unevaluatedProperties to fix dtbs_check warnings like: arch/arm/boot/dts/exynos5250-snow.dt.yaml: embedded-controller@1e: 'keyboard-controller', 'wakeup-source' do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)