| Message ID | 20200917164642.158458-1-fazilyildiran@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | net: ipv6: fix kconfig dependency warning for IPV6_SEG6_HMAC | expand |
From: Necip Fazil Yildiran <fazilyildiran@gmail.com> Date: Thu, 17 Sep 2020 19:46:43 +0300 > When IPV6_SEG6_HMAC is enabled and CRYPTO is disabled, it results in the > following Kbuild warning: > > WARNING: unmet direct dependencies detected for CRYPTO_HMAC > Depends on [n]: CRYPTO [=n] > Selected by [y]: > - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] > > WARNING: unmet direct dependencies detected for CRYPTO_SHA1 > Depends on [n]: CRYPTO [=n] > Selected by [y]: > - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] > > WARNING: unmet direct dependencies detected for CRYPTO_SHA256 > Depends on [n]: CRYPTO [=n] > Selected by [y]: > - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] > > The reason is that IPV6_SEG6_HMAC selects CRYPTO_HMAC, CRYPTO_SHA1, and > CRYPTO_SHA256 without depending on or selecting CRYPTO while those configs > are subordinate to CRYPTO. > > Honor the kconfig menu hierarchy to remove kconfig dependency warnings. > > Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support") > Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com> Applied and queued up for -stable, thank you.
diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig index 76bff79d6fed..747f56e0c636 100644 --- a/net/ipv6/Kconfig +++ b/net/ipv6/Kconfig @@ -303,6 +303,7 @@ config IPV6_SEG6_LWTUNNEL config IPV6_SEG6_HMAC bool "IPv6: Segment Routing HMAC support" depends on IPV6 + select CRYPTO select CRYPTO_HMAC select CRYPTO_SHA1 select CRYPTO_SHA256
When IPV6_SEG6_HMAC is enabled and CRYPTO is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for CRYPTO_HMAC Depends on [n]: CRYPTO [=n] Selected by [y]: - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] WARNING: unmet direct dependencies detected for CRYPTO_SHA1 Depends on [n]: CRYPTO [=n] Selected by [y]: - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] WARNING: unmet direct dependencies detected for CRYPTO_SHA256 Depends on [n]: CRYPTO [=n] Selected by [y]: - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] The reason is that IPV6_SEG6_HMAC selects CRYPTO_HMAC, CRYPTO_SHA1, and CRYPTO_SHA256 without depending on or selecting CRYPTO while those configs are subordinate to CRYPTO. Honor the kconfig menu hierarchy to remove kconfig dependency warnings. Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support") Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com> --- net/ipv6/Kconfig | 1 + 1 file changed, 1 insertion(+)