diff mbox series

[v3,5/5] net: phy: smsc: LAN8710/20: remove PHY_RST_AFTER_CLK_EN flag

Message ID 20200909134501.32529-6-m.felsch@pengutronix.de
State Superseded
Headers show
Series [v3,1/5] net: phy: smsc: skip ENERGYON interrupt if disabled | expand

Commit Message

Marco Felsch Sept. 9, 2020, 1:45 p.m. UTC
Don't reset the phy without respect to the PHY library state machine
because this breaks the phy IRQ mode. The same behaviour can be archived
now by specifying the refclk.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v3:
- s/phy-state-machine/PHY library state machine/
- reword last sentence of the commit message 

v2:
- no changes

 drivers/net/phy/smsc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Florian Fainelli Sept. 9, 2020, 3:43 p.m. UTC | #1
On 9/9/2020 6:45 AM, Marco Felsch wrote:
> Don't reset the phy without respect to the PHY library state machine
> because this breaks the phy IRQ mode. The same behaviour can be archived
> now by specifying the refclk.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff mbox series

Patch

diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index bdf8593e385e..75931d4acf10 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -331,7 +331,6 @@  static struct phy_driver smsc_phy_driver[] = {
 	.name		= "SMSC LAN8710/LAN8720",
 
 	/* PHY_BASIC_FEATURES */
-	.flags		= PHY_RST_AFTER_CLK_EN,
 
 	.probe		= smsc_phy_probe,
 	.remove		= smsc_phy_remove,