| Message ID | 20200901145841.14893-1-geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4 | expand |
From: Geert Uytterhoeven <geert+renesas@glider.be> Date: Tue, 1 Sep 2020 16:58:41 +0200 > While CHELSIO_INLINE_CRYPTO is a guard symbol, and just enabling it does > not cause any additional code to be compiled in, all configuration > options protected by it depend on CONFIG_CHELSIO_T4. Hence it doesn't > make much sense to bother the user with the guard symbol question when > CONFIG_CHELSIO_T4 is disabled. > > Fix this by moving the dependency from the individual config options to > the guard symbol. > > Fixes: 44fd1c1fd8219551 ("chelsio/chtls: separate chelsio tls driver from crypto driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied to net-next, thank you. Please clearly state the target tree in your future submissions, f.e. "Subject: [PATCH net-next] ..." Thanks again.
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/Kconfig b/drivers/net/ethernet/chelsio/inline_crypto/Kconfig index a3ef057031e4a50b..be70b59b6f8070e5 100644 --- a/drivers/net/ethernet/chelsio/inline_crypto/Kconfig +++ b/drivers/net/ethernet/chelsio/inline_crypto/Kconfig @@ -5,6 +5,7 @@ config CHELSIO_INLINE_CRYPTO bool "Chelsio Inline Crypto support" + depends on CHELSIO_T4 default y help Enable support for inline crypto. @@ -14,7 +15,6 @@ if CHELSIO_INLINE_CRYPTO config CRYPTO_DEV_CHELSIO_TLS tristate "Chelsio Crypto Inline TLS Driver" - depends on CHELSIO_T4 depends on TLS_TOE help Support Chelsio Inline TLS with Chelsio crypto accelerator. @@ -25,7 +25,6 @@ config CRYPTO_DEV_CHELSIO_TLS config CHELSIO_IPSEC_INLINE tristate "Chelsio IPSec XFRM Tx crypto offload" - depends on CHELSIO_T4 depends on XFRM_OFFLOAD depends on INET_ESP_OFFLOAD || INET6_ESP_OFFLOAD help
While CHELSIO_INLINE_CRYPTO is a guard symbol, and just enabling it does not cause any additional code to be compiled in, all configuration options protected by it depend on CONFIG_CHELSIO_T4. Hence it doesn't make much sense to bother the user with the guard symbol question when CONFIG_CHELSIO_T4 is disabled. Fix this by moving the dependency from the individual config options to the guard symbol. Fixes: 44fd1c1fd8219551 ("chelsio/chtls: separate chelsio tls driver from crypto driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/ethernet/chelsio/inline_crypto/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)