| Message ID | 160165476743.57452.2128307974125615413.stgit@bahia.lan |
|---|---|
| State | New |
| Headers | show |
| Series | hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties() | expand |
On 10/2/20 6:06 PM, Greg Kurz wrote: Maybe add "Fix a typo" to make it obvious. Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > hw/acpi/piix4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c > index 894d357f8c35..67a1ea41914f 100644 > --- a/hw/acpi/piix4.c > +++ b/hw/acpi/piix4.c > @@ -437,7 +437,7 @@ static void piix4_pm_machine_ready(Notifier *n, void *opaque) > (memory_region_present(io_as, 0x2f8) ? 0x90 : 0); > } > > -static void piix4_pm_add_propeties(PIIX4PMState *s) > +static void piix4_pm_add_properties(PIIX4PMState *s) > { > static const uint8_t acpi_enable_cmd = ACPI_ENABLE; > static const uint8_t acpi_disable_cmd = ACPI_DISABLE; > @@ -509,7 +509,7 @@ static void piix4_pm_realize(PCIDevice *dev, Error **errp) > pci_get_bus(dev), s); > qbus_set_hotplug_handler(BUS(pci_get_bus(dev)), OBJECT(s)); > > - piix4_pm_add_propeties(s); > + piix4_pm_add_properties(s); > } > > I2CBus *piix4_pm_init(PCIBus *bus, int devfn, uint32_t smb_io_base, > > >
Greg Kurz <groug@kaod.org> 于2020年10月3日周六 上午12:07写道： > > Signed-off-by: Greg Kurz <groug@kaod.org> Reviewed-by: Li Qiang <liq3ea@gmail.com> > --- > hw/acpi/piix4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c > index 894d357f8c35..67a1ea41914f 100644 > --- a/hw/acpi/piix4.c > +++ b/hw/acpi/piix4.c > @@ -437,7 +437,7 @@ static void piix4_pm_machine_ready(Notifier *n, void *opaque) > (memory_region_present(io_as, 0x2f8) ? 0x90 : 0); > } > > -static void piix4_pm_add_propeties(PIIX4PMState *s) > +static void piix4_pm_add_properties(PIIX4PMState *s) > { > static const uint8_t acpi_enable_cmd = ACPI_ENABLE; > static const uint8_t acpi_disable_cmd = ACPI_DISABLE; > @@ -509,7 +509,7 @@ static void piix4_pm_realize(PCIDevice *dev, Error **errp) > pci_get_bus(dev), s); > qbus_set_hotplug_handler(BUS(pci_get_bus(dev)), OBJECT(s)); > > - piix4_pm_add_propeties(s); > + piix4_pm_add_properties(s); > } > > I2CBus *piix4_pm_init(PCIBus *bus, int devfn, uint32_t smb_io_base, > > >
Le 02/10/2020 à 18:06, Greg Kurz a écrit : > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > hw/acpi/piix4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c > index 894d357f8c35..67a1ea41914f 100644 > --- a/hw/acpi/piix4.c > +++ b/hw/acpi/piix4.c > @@ -437,7 +437,7 @@ static void piix4_pm_machine_ready(Notifier *n, void *opaque) > (memory_region_present(io_as, 0x2f8) ? 0x90 : 0); > } > > -static void piix4_pm_add_propeties(PIIX4PMState *s) > +static void piix4_pm_add_properties(PIIX4PMState *s) > { > static const uint8_t acpi_enable_cmd = ACPI_ENABLE; > static const uint8_t acpi_disable_cmd = ACPI_DISABLE; > @@ -509,7 +509,7 @@ static void piix4_pm_realize(PCIDevice *dev, Error **errp) > pci_get_bus(dev), s); > qbus_set_hotplug_handler(BUS(pci_get_bus(dev)), OBJECT(s)); > > - piix4_pm_add_propeties(s); > + piix4_pm_add_properties(s); > } > > I2CBus *piix4_pm_init(PCIBus *bus, int devfn, uint32_t smb_io_base, > > > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 894d357f8c35..67a1ea41914f 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -437,7 +437,7 @@ static void piix4_pm_machine_ready(Notifier *n, void *opaque) (memory_region_present(io_as, 0x2f8) ? 0x90 : 0); } -static void piix4_pm_add_propeties(PIIX4PMState *s) +static void piix4_pm_add_properties(PIIX4PMState *s) { static const uint8_t acpi_enable_cmd = ACPI_ENABLE; static const uint8_t acpi_disable_cmd = ACPI_DISABLE; @@ -509,7 +509,7 @@ static void piix4_pm_realize(PCIDevice *dev, Error **errp) pci_get_bus(dev), s); qbus_set_hotplug_handler(BUS(pci_get_bus(dev)), OBJECT(s)); - piix4_pm_add_propeties(s); + piix4_pm_add_properties(s); } I2CBus *piix4_pm_init(PCIBus *bus, int devfn, uint32_t smb_io_base,
Signed-off-by: Greg Kurz <groug@kaod.org> --- hw/acpi/piix4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)