diff mbox series

[v2] modules: update qom object module comment

Message ID 20200923103728.12026-1-kraxel@redhat.com
State Superseded
Headers show
Series [v2] modules: update qom object module comment | expand

Commit Message

Gerd Hoffmann Sept. 23, 2020, 10:37 a.m. UTC 
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 util/module.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Sept. 23, 2020, 11 a.m. UTC | #1 
On 9/23/20 12:37 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  util/module.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/util/module.c b/util/module.c
> index 520986bd70ff..6eb1e917860e 100644
> --- a/util/module.c
> +++ b/util/module.c
> @@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const char *lib_name)
>   * only a very few devices & objects.
>   *
>   * So with the expectation that this will be rather the exception than
> - * to rule and the list will not gain that many entries go with a
> + * the rule and the list will not gain that many entries, go with a
>   * simple manually maintained list for now.
> + *
> + * The list must be sorted by module (module_load_qom_all() needs this).
>   */
>  static struct {
>      const char *type;
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff mbox series

Patch

diff --git a/util/module.c b/util/module.c
index 520986bd70ff..6eb1e917860e 100644
--- a/util/module.c
+++ b/util/module.c
@@ -255,8 +255,10 @@  bool module_load_one(const char *prefix, const char *lib_name)
  * only a very few devices & objects.
  *
  * So with the expectation that this will be rather the exception than
- * to rule and the list will not gain that many entries go with a
+ * the rule and the list will not gain that many entries, go with a
  * simple manually maintained list for now.
+ *
+ * The list must be sorted by module (module_load_qom_all() needs this).
  */
 static struct {
     const char *type;