diff mbox

ARM: OMAP3: hwmod_data: Correct clock domains for USB modules

Message ID 1397056615-4503-1-git-send-email-rogerq@ti.com
State Superseded
Headers show

Commit Message

Roger Quadros April 9, 2014, 3:16 p.m. UTC
OMAP3 doesn't contain "l3_init_clkdm" clock domain. Use the
proper clock domains for USB Host and USB TLL modules.

Gets rid of the following warnings during boot
 omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
 omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm

Reported-by: Nishant Menon <nm@ti.com>
CC: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Nishanth Menon April 9, 2014, 3:19 p.m. UTC | #1
On 04/09/2014 10:16 AM, Roger Quadros wrote:
> OMAP3 doesn't contain "l3_init_clkdm" clock domain. Use the
> proper clock domains for USB Host and USB TLL modules.
> 
> Gets rid of the following warnings during boot
>  omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
>  omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm
> 
> Reported-by: Nishant Menon <nm@ti.com>

I guess I have a "h" at the end of my first name :P


> CC: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 9c7e23a..3aa49ed 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -1968,7 +1968,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_host_hs_irqs[] = {
>  static struct omap_hwmod omap3xxx_usb_host_hs_hwmod = {
>  	.name		= "usb_host_hs",
>  	.class		= &omap3xxx_usb_host_hs_hwmod_class,
> -	.clkdm_name	= "l3_init_clkdm",
> +	.clkdm_name	= "usbhost_clkdm",
>  	.mpu_irqs	= omap3xxx_usb_host_hs_irqs,
>  	.main_clk	= "usbhost_48m_fck",
>  	.prcm = {
> @@ -2053,7 +2053,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_tll_hs_irqs[] = {
>  static struct omap_hwmod omap3xxx_usb_tll_hs_hwmod = {
>  	.name		= "usb_tll_hs",
>  	.class		= &omap3xxx_usb_tll_hs_hwmod_class,
> -	.clkdm_name	= "l3_init_clkdm",
> +	.clkdm_name	= "core_l4_clkdm",
>  	.mpu_irqs	= omap3xxx_usb_tll_hs_irqs,
>  	.main_clk	= "usbtll_fck",
>  	.prcm = {
>
Roger Quadros April 10, 2014, 7:13 a.m. UTC | #2
On 04/09/2014 06:19 PM, Nishanth Menon wrote:
> On 04/09/2014 10:16 AM, Roger Quadros wrote:
>> OMAP3 doesn't contain "l3_init_clkdm" clock domain. Use the
>> proper clock domains for USB Host and USB TLL modules.
>>
>> Gets rid of the following warnings during boot
>>  omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
>>  omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm
>>
>> Reported-by: Nishant Menon <nm@ti.com>
> 
> I guess I have a "h" at the end of my first name :P
> 
Sorry Nishanth. I'll send a revised patch.

cheers,
-roger

> 
>> CC: Paul Walmsley <paul@pwsan.com>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> index 9c7e23a..3aa49ed 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> @@ -1968,7 +1968,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_host_hs_irqs[] = {
>>  static struct omap_hwmod omap3xxx_usb_host_hs_hwmod = {
>>  	.name		= "usb_host_hs",
>>  	.class		= &omap3xxx_usb_host_hs_hwmod_class,
>> -	.clkdm_name	= "l3_init_clkdm",
>> +	.clkdm_name	= "usbhost_clkdm",
>>  	.mpu_irqs	= omap3xxx_usb_host_hs_irqs,
>>  	.main_clk	= "usbhost_48m_fck",
>>  	.prcm = {
>> @@ -2053,7 +2053,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_tll_hs_irqs[] = {
>>  static struct omap_hwmod omap3xxx_usb_tll_hs_hwmod = {
>>  	.name		= "usb_tll_hs",
>>  	.class		= &omap3xxx_usb_tll_hs_hwmod_class,
>> -	.clkdm_name	= "l3_init_clkdm",
>> +	.clkdm_name	= "core_l4_clkdm",
>>  	.mpu_irqs	= omap3xxx_usb_tll_hs_irqs,
>>  	.main_clk	= "usbtll_fck",
>>  	.prcm = {
>>
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
index 9c7e23a..3aa49ed 100644
--- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
@@ -1968,7 +1968,7 @@  static struct omap_hwmod_irq_info omap3xxx_usb_host_hs_irqs[] = {
 static struct omap_hwmod omap3xxx_usb_host_hs_hwmod = {
 	.name		= "usb_host_hs",
 	.class		= &omap3xxx_usb_host_hs_hwmod_class,
-	.clkdm_name	= "l3_init_clkdm",
+	.clkdm_name	= "usbhost_clkdm",
 	.mpu_irqs	= omap3xxx_usb_host_hs_irqs,
 	.main_clk	= "usbhost_48m_fck",
 	.prcm = {
@@ -2053,7 +2053,7 @@  static struct omap_hwmod_irq_info omap3xxx_usb_tll_hs_irqs[] = {
 static struct omap_hwmod omap3xxx_usb_tll_hs_hwmod = {
 	.name		= "usb_tll_hs",
 	.class		= &omap3xxx_usb_tll_hs_hwmod_class,
-	.clkdm_name	= "l3_init_clkdm",
+	.clkdm_name	= "core_l4_clkdm",
 	.mpu_irqs	= omap3xxx_usb_tll_hs_irqs,
 	.main_clk	= "usbtll_fck",
 	.prcm = {