| Message ID | 20201006141307.309650-1-jlayton@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | ceph: don't SetPageError on readpage errors | expand |
On Tue, Oct 06, 2020 at 10:13:07AM -0400, Jeff Layton wrote: > PageError really only has meaning within a particular subsystem. Nothing > looks at this bit in the core kernel code, and ceph itself doesn't care > about it. Don't bother setting the PageError bit on error. I wondered if fscache might be interested, but it seems like it doesn't particularly care. It's still interested in PageError for backing store pages, but not for the filesystem being cached. Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> > Cc: Matthew Wilcox <willy@infradead.org> > Signed-off-by: Jeff Layton <jlayton@kernel.org> > --- > fs/ceph/addr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 97827f68a3e7..137c0a5a2a0d 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -241,7 +241,6 @@ static int ceph_do_readpage(struct file *filp, struct page *page) > if (err == -ENOENT) > err = 0; > if (err < 0) { > - SetPageError(page); > ceph_fscache_readpage_cancel(inode, page); > if (err == -EBLOCKLISTED) > fsc->blocklisted = true; > -- > 2.26.2 >
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 97827f68a3e7..137c0a5a2a0d 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -241,7 +241,6 @@ static int ceph_do_readpage(struct file *filp, struct page *page) if (err == -ENOENT) err = 0; if (err < 0) { - SetPageError(page); ceph_fscache_readpage_cancel(inode, page); if (err == -EBLOCKLISTED) fsc->blocklisted = true;
PageError really only has meaning within a particular subsystem. Nothing looks at this bit in the core kernel code, and ceph itself doesn't care about it. Don't bother setting the PageError bit on error. Cc: Matthew Wilcox <willy@infradead.org> Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ceph/addr.c | 1 - 1 file changed, 1 deletion(-)