| Message ID | 1398693687-13967-6-git-send-email-rogerq@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Apr 28, 2014 at 05:01:25PM +0300, Roger Quadros wrote: > Add "wkupclk" and "refclk" information to DT binding information. > > Signed-off-by: Roger Quadros <rogerq@ti.com> Reviewed-by: Felipe Balbi <balbi@ti.com> > --- > Documentation/devicetree/bindings/phy/ti-phy.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt > index 788fb0f..9ce458f 100644 > --- a/Documentation/devicetree/bindings/phy/ti-phy.txt > +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt > @@ -32,6 +32,11 @@ Required properties: > - reg : Address and length of the register set for the device. > - #phy-cells: determine the number of cells that should be given in the > phandle while referencing this phy. > + - clocks: a list of phandles and clock-specifier pairs, one for each entry in > + clock-names. > + - clock-names: should include: > + * "wkupclk" - wakeup clock. > + * "refclk" - reference clock (optional). > > Optional properties: > - ctrl-module : phandle of the control module used by PHY driver to power on > @@ -44,6 +49,8 @@ usb2phy@4a0ad080 { > reg = <0x4a0ad080 0x58>; > ctrl-module = <&omap_control_usb>; > #phy-cells = <0>; > + clocks = <&usb_phy_cm_clk32k>, <&usb_otg_ss_refclk960m>; > + clock-names = "wkupclk", "refclk"; > }; > > TI PIPE3 PHY > -- > 1.8.3.2 >
Hello. On 04/28/2014 06:01 PM, Roger Quadros wrote: > Add "wkupclk" and "refclk" information to DT binding information. > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > Documentation/devicetree/bindings/phy/ti-phy.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt > index 788fb0f..9ce458f 100644 > --- a/Documentation/devicetree/bindings/phy/ti-phy.txt > +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt > @@ -32,6 +32,11 @@ Required properties: > - reg : Address and length of the register set for the device. > - #phy-cells: determine the number of cells that should be given in the > phandle while referencing this phy. > + - clocks: a list of phandles and clock-specifier pairs, one for each entry in > + clock-names. I thought clock specifier includes phandle. Anyway, this description doesn't seem to match your example... > + - clock-names: should include: > + * "wkupclk" - wakeup clock. > + * "refclk" - reference clock (optional). > > Optional properties: > - ctrl-module : phandle of the control module used by PHY driver to power on > @@ -44,6 +49,8 @@ usb2phy@4a0ad080 { > reg = <0x4a0ad080 0x58>; > ctrl-module = <&omap_control_usb>; > #phy-cells = <0>; > + clocks = <&usb_phy_cm_clk32k>, <&usb_otg_ss_refclk960m>; > + clock-names = "wkupclk", "refclk"; > }; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sergei, On 04/28/2014 08:23 PM, Sergei Shtylyov wrote: > Hello. > > On 04/28/2014 06:01 PM, Roger Quadros wrote: > >> Add "wkupclk" and "refclk" information to DT binding information. > >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> Documentation/devicetree/bindings/phy/ti-phy.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) > >> diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt >> index 788fb0f..9ce458f 100644 >> --- a/Documentation/devicetree/bindings/phy/ti-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt >> @@ -32,6 +32,11 @@ Required properties: >> - reg : Address and length of the register set for the device. >> - #phy-cells: determine the number of cells that should be given in the >> phandle while referencing this phy. >> + - clocks: a list of phandles and clock-specifier pairs, one for each entry in >> + clock-names. > > I thought clock specifier includes phandle. Anyway, this description doesn't seem to match your example... http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/clock-bindings.txt#n64 The example was taken from real world where the clock doesn't need specifier. Examples can always be a subset of supported bindings. cheers, -roger > >> + - clock-names: should include: >> + * "wkupclk" - wakeup clock. >> + * "refclk" - reference clock (optional). >> >> Optional properties: >> - ctrl-module : phandle of the control module used by PHY driver to power on >> @@ -44,6 +49,8 @@ usb2phy@4a0ad080 { >> reg = <0x4a0ad080 0x58>; >> ctrl-module = <&omap_control_usb>; >> #phy-cells = <0>; >> + clocks = <&usb_phy_cm_clk32k>, <&usb_otg_ss_refclk960m>; >> + clock-names = "wkupclk", "refclk"; >> }; > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt index 788fb0f..9ce458f 100644 --- a/Documentation/devicetree/bindings/phy/ti-phy.txt +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt @@ -32,6 +32,11 @@ Required properties: - reg : Address and length of the register set for the device. - #phy-cells: determine the number of cells that should be given in the phandle while referencing this phy. + - clocks: a list of phandles and clock-specifier pairs, one for each entry in + clock-names. + - clock-names: should include: + * "wkupclk" - wakeup clock. + * "refclk" - reference clock (optional). Optional properties: - ctrl-module : phandle of the control module used by PHY driver to power on @@ -44,6 +49,8 @@ usb2phy@4a0ad080 { reg = <0x4a0ad080 0x58>; ctrl-module = <&omap_control_usb>; #phy-cells = <0>; + clocks = <&usb_phy_cm_clk32k>, <&usb_otg_ss_refclk960m>; + clock-names = "wkupclk", "refclk"; }; TI PIPE3 PHY
Add "wkupclk" and "refclk" information to DT binding information. Signed-off-by: Roger Quadros <rogerq@ti.com> --- Documentation/devicetree/bindings/phy/ti-phy.txt | 7 +++++++ 1 file changed, 7 insertions(+)