diff mbox series

virtiofsd: document cache=auto default

Message ID 20200916112250.760245-1-stefanha@redhat.com
State New
Headers show
Series virtiofsd: document cache=auto default | expand

Commit Message

Stefan Hajnoczi Sept. 16, 2020, 11:22 a.m. UTC
From: "Harry G. Coin" <hgcoin@gmail.com>

The virtiofsd --help output documents the cache=auto default value but
the man page does not. Fix this.

Signed-off-by: Harry G. Coin <hgcoin@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 docs/tools/virtiofsd.rst | 1 +
 1 file changed, 1 insertion(+)

Comments

Dr. David Alan Gilbert Sept. 21, 2020, 9:10 a.m. UTC | #1
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> From: "Harry G. Coin" <hgcoin@gmail.com>

> 

> The virtiofsd --help output documents the cache=auto default value but

> the man page does not. Fix this.

> 

> Signed-off-by: Harry G. Coin <hgcoin@gmail.com>

> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>


Thanks, I'll add it to the next pull.

Dave


> ---

>  docs/tools/virtiofsd.rst | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst

> index e33c81ed41..352a29ce3c 100644

> --- a/docs/tools/virtiofsd.rst

> +++ b/docs/tools/virtiofsd.rst

> @@ -103,6 +103,7 @@ Options

>    forbids the FUSE client from caching to achieve best coherency at the cost of

>    performance.  ``auto`` acts similar to NFS with a 1 second metadata cache

>    timeout.  ``always`` sets a long cache lifetime at the expense of coherency.

> +  The default is ``auto``.

>  

>  Examples

>  --------

> -- 

> 2.26.2

> 

-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Dr. David Alan Gilbert Sept. 24, 2020, 9:19 a.m. UTC | #2
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> From: "Harry G. Coin" <hgcoin@gmail.com>

> 

> The virtiofsd --help output documents the cache=auto default value but

> the man page does not. Fix this.

> 

> Signed-off-by: Harry G. Coin <hgcoin@gmail.com>

> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


Queued

> ---

>  docs/tools/virtiofsd.rst | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst

> index e33c81ed41..352a29ce3c 100644

> --- a/docs/tools/virtiofsd.rst

> +++ b/docs/tools/virtiofsd.rst

> @@ -103,6 +103,7 @@ Options

>    forbids the FUSE client from caching to achieve best coherency at the cost of

>    performance.  ``auto`` acts similar to NFS with a 1 second metadata cache

>    timeout.  ``always`` sets a long cache lifetime at the expense of coherency.

> +  The default is ``auto``.

>  

>  Examples

>  --------

> -- 

> 2.26.2

> 

-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff mbox series

Patch

diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
index e33c81ed41..352a29ce3c 100644
--- a/docs/tools/virtiofsd.rst
+++ b/docs/tools/virtiofsd.rst
@@ -103,6 +103,7 @@  Options
   forbids the FUSE client from caching to achieve best coherency at the cost of
   performance.  ``auto`` acts similar to NFS with a 1 second metadata cache
   timeout.  ``always`` sets a long cache lifetime at the expense of coherency.
+  The default is ``auto``.
 
 Examples
 --------