| Message ID | 1401361534-25997-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Commit | f2e2bc9ca06a1c2c6b300c19d4b938c7273a2f76 |
| Headers | show |
On 29.05.14 13:05, Peter Maydell wrote: > Fix a typo in the ppce500_pci vmstate definition which meant that > we were migrating the struct pci_inbound using the vmstate for > pci_outbound. Fortunately the two structures have exactly the same > format at the moment (four uint32_ts) so this was harmless, and > we can correcting the typo without a migration compatibility > break because the vmstate name doesn't go out on the wire. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > Big fat disclaimer: I believe the remark about this not > being a compat break to be true, but I haven't tested it! Ouch. I'm fairly sure we don't have migration users on e500, so we're safe. Thanks a lot for catching this! Applied to ppc-next Alex
On 30 May 2014 09:19, Alexander Graf <agraf@suse.de> wrote: > Ouch. I'm fairly sure we don't have migration users on e500, > so we're safe. Thanks a lot for catching this! Thank clang 3.4, which noticed that the vmstate_pci_inbound variable was never used... -- PMM
diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c index c80b7cb..5ce7433 100644 --- a/hw/pci-host/ppce500.c +++ b/hw/pci-host/ppce500.c @@ -311,7 +311,7 @@ static const VMStateDescription vmstate_ppce500_pci = { VMSTATE_STRUCT_ARRAY(pob, PPCE500PCIState, PPCE500_PCI_NR_POBS, 1, vmstate_pci_outbound, struct pci_outbound), VMSTATE_STRUCT_ARRAY(pib, PPCE500PCIState, PPCE500_PCI_NR_PIBS, 1, - vmstate_pci_outbound, struct pci_inbound), + vmstate_pci_inbound, struct pci_inbound), VMSTATE_UINT32(gasket_time, PPCE500PCIState), VMSTATE_END_OF_LIST() }
Fix a typo in the ppce500_pci vmstate definition which meant that we were migrating the struct pci_inbound using the vmstate for pci_outbound. Fortunately the two structures have exactly the same format at the moment (four uint32_ts) so this was harmless, and we can correcting the typo without a migration compatibility break because the vmstate name doesn't go out on the wire. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- Big fat disclaimer: I believe the remark about this not being a compat break to be true, but I haven't tested it! --- hw/pci-host/ppce500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)