| Message ID | 20201106041513.38481-2-samuel@sholland.org |
|---|---|
| State | New |
| Headers | show |
| Series | PinePhone BT audio bringup | expand |
On Thu, 05 Nov 2020 22:15:07 -0600, Samuel Holland wrote: > Increase sound-dai-cells to 1 to allow using the DAIs in the codec > corresponding to AIF2 and AIF3. > > The generic ASoC OF code supports a #sound-dai-cells value of 0 or 1 > with no impact to the driver, so this is a backward-compatible change. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > .../devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.example.dt.yaml: audio-codec@1c22e00: #sound-dai-cells:0:0: 1 was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml See https://patchwork.ozlabs.org/patch/1395481 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml index 67405e6d8168..1a2590f54b9b 100644 --- a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml +++ b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml @@ -12,7 +12,7 @@ maintainers: properties: "#sound-dai-cells": - const: 0 + const: 1 compatible: oneOf:
Increase sound-dai-cells to 1 to allow using the DAIs in the codec corresponding to AIF2 and AIF3. The generic ASoC OF code supports a #sound-dai-cells value of 0 or 1 with no impact to the driver, so this is a backward-compatible change. Signed-off-by: Samuel Holland <samuel@sholland.org> --- .../devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)