| Message ID | 20201203120212.1105-2-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: reset: convert Hisilicon reset controller bindings to json-schema | expand |
On Thu, 2020-12-03 at 20:02 +0800, Zhen Lei wrote: > The vendor prefix of "Hisilicon Limited" is "hisilicon", it is clearly > stated in "vendor-prefixes.yaml". > > Fixes: 1527058736fa ("reset: hisilicon: add reset-hi3660") > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > Cc: Zhangfei Gao <zhangfei.gao@linaro.org> > --- > drivers/reset/hisilicon/reset-hi3660.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/reset/hisilicon/reset-hi3660.c b/drivers/reset/hisilicon/reset-hi3660.c > index a7d4445924e558c..8f1953159a65b31 100644 > --- a/drivers/reset/hisilicon/reset-hi3660.c > +++ b/drivers/reset/hisilicon/reset-hi3660.c > @@ -83,7 +83,7 @@ static int hi3660_reset_probe(struct platform_device *pdev) > if (!rc) > return -ENOMEM; > > - rc->map = syscon_regmap_lookup_by_phandle(np, "hisi,rst-syscon"); > + rc->map = syscon_regmap_lookup_by_phandle(np, "hisilicon,rst-syscon"); What about those that don't upgrade kernel and DT in lock-step? It would be easy to fall back to the old compatible if the new one fails. regards Philipp
On 2020/12/3 20:54, Philipp Zabel wrote: > On Thu, 2020-12-03 at 20:02 +0800, Zhen Lei wrote: >> The vendor prefix of "Hisilicon Limited" is "hisilicon", it is clearly >> stated in "vendor-prefixes.yaml". >> >> Fixes: 1527058736fa ("reset: hisilicon: add reset-hi3660") >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> >> Cc: Zhangfei Gao <zhangfei.gao@linaro.org> >> --- >> drivers/reset/hisilicon/reset-hi3660.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/reset/hisilicon/reset-hi3660.c b/drivers/reset/hisilicon/reset-hi3660.c >> index a7d4445924e558c..8f1953159a65b31 100644 >> --- a/drivers/reset/hisilicon/reset-hi3660.c >> +++ b/drivers/reset/hisilicon/reset-hi3660.c >> @@ -83,7 +83,7 @@ static int hi3660_reset_probe(struct platform_device *pdev) >> if (!rc) >> return -ENOMEM; >> >> - rc->map = syscon_regmap_lookup_by_phandle(np, "hisi,rst-syscon"); >> + rc->map = syscon_regmap_lookup_by_phandle(np, "hisilicon,rst-syscon"); > > What about those that don't upgrade kernel and DT in lock-step? > It would be easy to fall back to the old compatible if the new one > fails. All right, I'll combine them. I thought they belonged to different maintainers, and I had to break them apart. > > regards > Philipp > > . >
diff --git a/drivers/reset/hisilicon/reset-hi3660.c b/drivers/reset/hisilicon/reset-hi3660.c index a7d4445924e558c..8f1953159a65b31 100644 --- a/drivers/reset/hisilicon/reset-hi3660.c +++ b/drivers/reset/hisilicon/reset-hi3660.c @@ -83,7 +83,7 @@ static int hi3660_reset_probe(struct platform_device *pdev) if (!rc) return -ENOMEM; - rc->map = syscon_regmap_lookup_by_phandle(np, "hisi,rst-syscon"); + rc->map = syscon_regmap_lookup_by_phandle(np, "hisilicon,rst-syscon"); if (IS_ERR(rc->map)) { dev_err(dev, "failed to get hi3660,rst-syscon\n"); return PTR_ERR(rc->map);
The vendor prefix of "Hisilicon Limited" is "hisilicon", it is clearly stated in "vendor-prefixes.yaml". Fixes: 1527058736fa ("reset: hisilicon: add reset-hi3660") Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Cc: Zhangfei Gao <zhangfei.gao@linaro.org> --- drivers/reset/hisilicon/reset-hi3660.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3