diff mbox

[PULL,1/8] slirp: Give error message if hostfwd_add/remove for unrecognized vlan/stack

Message ID 1405692553-564-2-git-send-email-mjt@msgid.tls.msk.ru
State Accepted
Commit b739ef05dbaffcaade5e756a70f91cdf9c327154
Headers show

Commit Message

Michael Tokarev July 18, 2014, 2:09 p.m. UTC 
From: Peter Maydell <peter.maydell@linaro.org>

If the user specified a (vlan ID, slirp stack name) tuple in a monitor
hostfwd_add/remove command and we can't find it, give the user an
error message rather than silently doing nothing.

This brings this error case in slirp_lookup() into line with the
other two.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 net/slirp.c |    1 +
 1 file changed, 1 insertion(+)
diff mbox

Patch

diff --git a/net/slirp.c b/net/slirp.c
index 8fddc03..647039e 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -282,6 +282,7 @@  static SlirpState *slirp_lookup(Monitor *mon, const char *vlan,
         NetClientState *nc;
         nc = net_hub_find_client_by_name(strtol(vlan, NULL, 0), stack);
         if (!nc) {
+            monitor_printf(mon, "unrecognized (vlan-id, stackname) pair\n");
             return NULL;
         }
         if (strcmp(nc->model, "user")) {