| Message ID | 20201210121514.25760-4-daniel.lezcano@linaro.org |
|---|---|
| State | Accepted |
| Commit | 1fa34e49e4b7e66214a1d15261c0224d60366eec |
| Headers | show |
| Series | [1/5] thermal/core: Emit a warning if the thermal zone is updated without ops | expand |
Hi Daniel, Thanks for your work. On 2020-12-10 13:15:13 +0100, Daniel Lezcano wrote: > The ops is only showing a trace telling a critical trip point is > crossed. The same information is given by the thermal framework. > > This is redundant, remove the code. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/thermal/rcar_thermal.c | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > index 6ae757d66f46..b49f04daaf47 100644 > --- a/drivers/thermal/rcar_thermal.c > +++ b/drivers/thermal/rcar_thermal.c > @@ -323,24 +323,6 @@ static int rcar_thermal_get_trip_temp(struct thermal_zone_device *zone, > return 0; > } > > -static int rcar_thermal_notify(struct thermal_zone_device *zone, > - int trip, enum thermal_trip_type type) > -{ > - struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone); > - struct device *dev = rcar_priv_to_dev(priv); > - > - switch (type) { > - case THERMAL_TRIP_CRITICAL: > - /* FIXME */ > - dev_warn(dev, "Thermal reached to critical temperature\n"); > - break; > - default: > - break; > - } > - > - return 0; > -} > - > static const struct thermal_zone_of_device_ops rcar_thermal_zone_of_ops = { > .get_temp = rcar_thermal_of_get_temp, > }; > @@ -349,7 +331,6 @@ static struct thermal_zone_device_ops rcar_thermal_zone_ops = { > .get_temp = rcar_thermal_get_temp, > .get_trip_type = rcar_thermal_get_trip_type, > .get_trip_temp = rcar_thermal_get_trip_temp, > - .notify = rcar_thermal_notify, > }; > > /* > -- > 2.17.1 > -- Regards, Niklas Söderlund
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index 6ae757d66f46..b49f04daaf47 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -323,24 +323,6 @@ static int rcar_thermal_get_trip_temp(struct thermal_zone_device *zone, return 0; } -static int rcar_thermal_notify(struct thermal_zone_device *zone, - int trip, enum thermal_trip_type type) -{ - struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone); - struct device *dev = rcar_priv_to_dev(priv); - - switch (type) { - case THERMAL_TRIP_CRITICAL: - /* FIXME */ - dev_warn(dev, "Thermal reached to critical temperature\n"); - break; - default: - break; - } - - return 0; -} - static const struct thermal_zone_of_device_ops rcar_thermal_zone_of_ops = { .get_temp = rcar_thermal_of_get_temp, }; @@ -349,7 +331,6 @@ static struct thermal_zone_device_ops rcar_thermal_zone_ops = { .get_temp = rcar_thermal_get_temp, .get_trip_type = rcar_thermal_get_trip_type, .get_trip_temp = rcar_thermal_get_trip_temp, - .notify = rcar_thermal_notify, }; /*
The ops is only showing a trace telling a critical trip point is crossed. The same information is given by the thermal framework. This is redundant, remove the code. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/thermal/rcar_thermal.c | 19 ------------------- 1 file changed, 19 deletions(-) -- 2.17.1