diff mbox series

[v2] fsp: Move and rename fsp_types.h file

Message ID 20201214062244.4949-1-sughosh.ganu@linaro.org
State Superseded
Headers show
Series [v2] fsp: Move and rename fsp_types.h file | expand

Commit Message

Sughosh Ganu Dec. 14, 2020, 6:22 a.m. UTC 
The fsp_types.h header file contains macros for building signatures of
different widths. These signature macros are architecture agnostic,
and can be used in all places which use signatures in a data
structure. Move and rename the fsp_types.h under the common include
header.

Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>

---

Changes since v1:
    Handled review comments from Simon Glass

Build tested for cougarcanyon2 board which builds the
relevant fsp code.

 arch/x86/include/asm/fsp/fsp_support.h                      | 3 ++-
 .../x86/include/asm/fsp/fsp_types.h => include/signatures.h | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)
 rename arch/x86/include/asm/fsp/fsp_types.h => include/signatures.h (95%)

-- 
2.17.1

Comments

Simon Glass Dec. 15, 2020, 3:55 a.m. UTC | #1 
Hi Sughosh,

On Sun, 13 Dec 2020 at 23:23, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>

> The fsp_types.h header file contains macros for building signatures of

> different widths. These signature macros are architecture agnostic,

> and can be used in all places which use signatures in a data

> structure. Move and rename the fsp_types.h under the common include

> header.

>

> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>

> ---

>

> Changes since v1:

>     Handled review comments from Simon Glass


(best to mention the changes you made rather than the name of your
reviewer, since that won't mean much to others)

>

> Build tested for cougarcanyon2 board which builds the

> relevant fsp code.

>

>  arch/x86/include/asm/fsp/fsp_support.h                      | 3 ++-

>  .../x86/include/asm/fsp/fsp_types.h => include/signatures.h | 6 +++---

>  2 files changed, 5 insertions(+), 4 deletions(-)

>  rename arch/x86/include/asm/fsp/fsp_types.h => include/signatures.h (95%)


Reviewed-by: Simon Glass <sjg@chromium.org>



>

> diff --git a/arch/x86/include/asm/fsp/fsp_support.h b/arch/x86/include/asm/fsp/fsp_support.h

> index 29e511415c..3cd3e4fcf5 100644

> --- a/arch/x86/include/asm/fsp/fsp_support.h

> +++ b/arch/x86/include/asm/fsp/fsp_support.h

> @@ -7,11 +7,12 @@

>  #ifndef __FSP_SUPPORT_H__

>  #define __FSP_SUPPORT_H__

>

> +#include <signatures.h>

> +

>  #include <asm/fsp/fsp_bootmode.h>

>  #include <asm/fsp/fsp_fv.h>

>  #include <asm/fsp/fsp_hob.h>

>  #include <asm/fsp/fsp_infoheader.h>

> -#include <asm/fsp/fsp_types.h>

>  #include <asm/fsp_arch.h>

>  #include <asm/fsp/fsp_azalia.h>

>

> diff --git a/arch/x86/include/asm/fsp/fsp_types.h b/include/signatures.h

> similarity index 95%

> rename from arch/x86/include/asm/fsp/fsp_types.h

> rename to include/signatures.h

> index 3d5b17ecf1..4042db1e00 100644

> --- a/arch/x86/include/asm/fsp/fsp_types.h

> +++ b/include/signatures.h

> @@ -4,8 +4,8 @@

>   * Copyright (C) 2014, Bin Meng <bmeng.cn@gmail.com>

>   */

>

> -#ifndef __FSP_TYPES_H__

> -#define __FSP_TYPES_H__

> +#ifndef __SIGNATURES_H__

> +#define __SIGNATURES_H__

>

>  /**

>   * Returns a 16-bit signature built from 2 ASCII characters.

> @@ -59,4 +59,4 @@

>  #define SIGNATURE_64(A, B, C, D, E, F, G, H)   \

>         (SIGNATURE_32(A, B, C, D) | ((u64)(SIGNATURE_32(E, F, G, H)) << 32))

>

> -#endif

> +#endif /* __SIGNATURES_H__ */

> --

> 2.17.1

>
Sughosh Ganu Dec. 15, 2020, 6:37 a.m. UTC | #2 
hi Simon,

On Tue, 15 Dec 2020 at 09:25, Simon Glass <sjg@chromium.org> wrote:

> Hi Sughosh,

>

> On Sun, 13 Dec 2020 at 23:23, Sughosh Ganu <sughosh.ganu@linaro.org>

> wrote:

> >

> > The fsp_types.h header file contains macros for building signatures of

> > different widths. These signature macros are architecture agnostic,

> > and can be used in all places which use signatures in a data

> > structure. Move and rename the fsp_types.h under the common include

> > header.

> >

> > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>

> > ---

> >

> > Changes since v1:

> >     Handled review comments from Simon Glass

>

> (best to mention the changes you made rather than the name of your

> reviewer, since that won't mean much to others)

>


Sure, will keep this in mind henceforth. Thanks.

-sughosh


>

> >

> > Build tested for cougarcanyon2 board which builds the

> > relevant fsp code.

> >

> >  arch/x86/include/asm/fsp/fsp_support.h                      | 3 ++-

> >  .../x86/include/asm/fsp/fsp_types.h => include/signatures.h | 6 +++---

> >  2 files changed, 5 insertions(+), 4 deletions(-)

> >  rename arch/x86/include/asm/fsp/fsp_types.h => include/signatures.h

> (95%)

>

> Reviewed-by: Simon Glass <sjg@chromium.org>

>

>

> >

> > diff --git a/arch/x86/include/asm/fsp/fsp_support.h

> b/arch/x86/include/asm/fsp/fsp_support.h

> > index 29e511415c..3cd3e4fcf5 100644

> > --- a/arch/x86/include/asm/fsp/fsp_support.h

> > +++ b/arch/x86/include/asm/fsp/fsp_support.h

> > @@ -7,11 +7,12 @@

> >  #ifndef __FSP_SUPPORT_H__

> >  #define __FSP_SUPPORT_H__

> >

> > +#include <signatures.h>

> > +

> >  #include <asm/fsp/fsp_bootmode.h>

> >  #include <asm/fsp/fsp_fv.h>

> >  #include <asm/fsp/fsp_hob.h>

> >  #include <asm/fsp/fsp_infoheader.h>

> > -#include <asm/fsp/fsp_types.h>

> >  #include <asm/fsp_arch.h>

> >  #include <asm/fsp/fsp_azalia.h>

> >

> > diff --git a/arch/x86/include/asm/fsp/fsp_types.h b/include/signatures.h

> > similarity index 95%

> > rename from arch/x86/include/asm/fsp/fsp_types.h

> > rename to include/signatures.h

> > index 3d5b17ecf1..4042db1e00 100644

> > --- a/arch/x86/include/asm/fsp/fsp_types.h

> > +++ b/include/signatures.h

> > @@ -4,8 +4,8 @@

> >   * Copyright (C) 2014, Bin Meng <bmeng.cn@gmail.com>

> >   */

> >

> > -#ifndef __FSP_TYPES_H__

> > -#define __FSP_TYPES_H__

> > +#ifndef __SIGNATURES_H__

> > +#define __SIGNATURES_H__

> >

> >  /**

> >   * Returns a 16-bit signature built from 2 ASCII characters.

> > @@ -59,4 +59,4 @@

> >  #define SIGNATURE_64(A, B, C, D, E, F, G, H)   \

> >         (SIGNATURE_32(A, B, C, D) | ((u64)(SIGNATURE_32(E, F, G, H)) <<

> 32))

> >

> > -#endif

> > +#endif /* __SIGNATURES_H__ */

> > --

> > 2.17.1

> >

>
Bin Meng Dec. 22, 2020, 2:20 a.m. UTC | #3 
On Mon, Dec 14, 2020 at 2:23 PM Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>

> The fsp_types.h header file contains macros for building signatures of

> different widths. These signature macros are architecture agnostic,

> and can be used in all places which use signatures in a data

> structure. Move and rename the fsp_types.h under the common include

> header.

>

> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>

> ---

>

> Changes since v1:

>     Handled review comments from Simon Glass

>

> Build tested for cougarcanyon2 board which builds the

> relevant fsp code.

>

>  arch/x86/include/asm/fsp/fsp_support.h                      | 3 ++-

>  .../x86/include/asm/fsp/fsp_types.h => include/signatures.h | 6 +++---

>  2 files changed, 5 insertions(+), 4 deletions(-)

>  rename arch/x86/include/asm/fsp/fsp_types.h => include/signatures.h (95%)

>


applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/arch/x86/include/asm/fsp/fsp_support.h b/arch/x86/include/asm/fsp/fsp_support.h
index 29e511415c..3cd3e4fcf5 100644
--- a/arch/x86/include/asm/fsp/fsp_support.h
+++ b/arch/x86/include/asm/fsp/fsp_support.h
@@ -7,11 +7,12 @@ 
 #ifndef __FSP_SUPPORT_H__
 #define __FSP_SUPPORT_H__
 
+#include <signatures.h>
+
 #include <asm/fsp/fsp_bootmode.h>
 #include <asm/fsp/fsp_fv.h>
 #include <asm/fsp/fsp_hob.h>
 #include <asm/fsp/fsp_infoheader.h>
-#include <asm/fsp/fsp_types.h>
 #include <asm/fsp_arch.h>
 #include <asm/fsp/fsp_azalia.h>
 
diff --git a/arch/x86/include/asm/fsp/fsp_types.h b/include/signatures.h
similarity index 95%
rename from arch/x86/include/asm/fsp/fsp_types.h
rename to include/signatures.h
index 3d5b17ecf1..4042db1e00 100644
--- a/arch/x86/include/asm/fsp/fsp_types.h
+++ b/include/signatures.h
@@ -4,8 +4,8 @@ 
  * Copyright (C) 2014, Bin Meng <bmeng.cn@gmail.com>
  */
 
-#ifndef __FSP_TYPES_H__
-#define __FSP_TYPES_H__
+#ifndef __SIGNATURES_H__
+#define __SIGNATURES_H__
 
 /**
  * Returns a 16-bit signature built from 2 ASCII characters.
@@ -59,4 +59,4 @@ 
 #define SIGNATURE_64(A, B, C, D, E, F, G, H)	\
 	(SIGNATURE_32(A, B, C, D) | ((u64)(SIGNATURE_32(E, F, G, H)) << 32))
 
-#endif
+#endif /* __SIGNATURES_H__ */