| Message ID | 1406551883-26154-8-git-send-email-haojian.zhuang@linaro.org |
|---|---|
| State | Changes Requested |
| Headers | show |
On Monday 28 July 2014 20:51:22 Haojian Zhuang wrote: > DT_MACHINE_START(HIX5HD2_DT, "Hisilicon HIX5HD2 (Flattened Device Tree)") > .dt_compat = hix5hd2_compat, > + .l2c_aux_val = 0x00050000, > + .l2c_aux_mask = 0xfff0ffff, > .smp = smp_ops(hix5hd2_smp_ops), > MACHINE_END What is wrong with the default settings as passed by the boot loader as you do for Hi3620? You should be able to just used 0x0 and 0xffffffff here, unless there is a bug in the hardware and/or the boot loader. You can also override certain settings by adding the appropriate properties to the l2x0 device node. Sorry, but this patch is not good as-is. Arnd
diff --git a/arch/arm/mach-hisi/hisilicon.c b/arch/arm/mach-hisi/hisilicon.c index 7996c6b..284f9a1 100644 --- a/arch/arm/mach-hisi/hisilicon.c +++ b/arch/arm/mach-hisi/hisilicon.c @@ -55,6 +55,8 @@ static const char *hi3xxx_compat[] __initconst = { DT_MACHINE_START(HI3620, "Hisilicon Hi3620 (Flattened Device Tree)") .map_io = hi3620_map_io, .dt_compat = hi3xxx_compat, + .l2c_aux_val = 0x0, + .l2c_aux_mask = 0xffffffff, .smp = smp_ops(hi3xxx_smp_ops), MACHINE_END @@ -65,5 +67,7 @@ static const char *hix5hd2_compat[] __initconst = { DT_MACHINE_START(HIX5HD2_DT, "Hisilicon HIX5HD2 (Flattened Device Tree)") .dt_compat = hix5hd2_compat, + .l2c_aux_val = 0x00050000, + .l2c_aux_mask = 0xfff0ffff, .smp = smp_ops(hix5hd2_smp_ops), MACHINE_END
Enable L2 aux value for both HI3xxx and HIX5HD2. Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org> --- arch/arm/mach-hisi/hisilicon.c | 4 ++++ 1 file changed, 4 insertions(+)