| Message ID | X9nGNJjFi9AaBBwX@mwanda |
|---|---|
| State | New |
| Headers | show |
| Series | Input: da7280 - delete a stray tab | expand |
On Wednesday, December 16, 2020 5:33 PM, Dan Carpenter wrote: > This line is indented one tab too far. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- Thanks for the patch but it is already fixed by Dmitry as below. --- An "if" testing for error condition has accidentally been dropped from the code. error = device_property_read_string(dev, gpi_str3, &str); + if (!error) haptics->gpi_ctl[i].polarity = da7280_haptic_of_gpi_pol_str(dev, str); Kind regards, Roy
diff --git a/drivers/input/misc/da7280.c b/drivers/input/misc/da7280.c index 37568b00873d..fe06693579ca 100644 --- a/drivers/input/misc/da7280.c +++ b/drivers/input/misc/da7280.c @@ -863,7 +863,7 @@ static void da7280_parse_properties(struct device *dev, gpi_str3[7] = '0' + i; haptics->gpi_ctl[i].polarity = 0; error = device_property_read_string(dev, gpi_str3, &str); - haptics->gpi_ctl[i].polarity = + haptics->gpi_ctl[i].polarity = da7280_haptic_of_gpi_pol_str(dev, str); }
This line is indented one tab too far. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/input/misc/da7280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)