| Message ID | alpine.DEB.2.02.1408111250150.2293@kaball.uk.xensource.com |
|---|---|
| State | Accepted |
| Commit | fb498df0787db0fb10a4a2cf91d0d3da13cc18f7 |
| Headers | show |
On 11/08/14 12:54, Stefano Stabellini wrote: > The backend type is chosen by the toolstack. Regardless, the frontend > should not care, especially given that it cannot have an effect as the > backend is started before this code is run. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Reviewed-by: David Vrabel <david.vrabel@citrix.com> This needs go via the TTY subsystem (you didn't Cc the maintainers). David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
CC'ing tty maintainers. On Mon, 11 Aug 2014, Stefano Stabellini wrote: > The backend type is chosen by the toolstack. Regardless, the frontend > should not care, especially given that it cannot have an effect as the > backend is started before this code is run. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c > index 636c9ba..b8491f5 100644 > --- a/drivers/tty/hvc/hvc_xen.c > +++ b/drivers/tty/hvc/hvc_xen.c > @@ -402,9 +402,6 @@ static int xencons_connect_backend(struct xenbus_device *dev, > evtchn); > if (ret) > goto error_xenbus; > - ret = xenbus_printf(xbt, dev->nodename, "type", "ioemu"); > - if (ret) > - goto error_xenbus; > ret = xenbus_transaction_end(xbt, 0); > if (ret) { > if (ret == -EAGAIN) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Mon, Aug 11, 2014 at 03:32:48PM +0100, Stefano Stabellini wrote:
> CC'ing tty maintainers.
Why? Is that how you submit a patch to be included to the kernel tree?
(hint, the answer is no, and also you should cc: the linux-serial
list...)
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, 12 Aug 2014, Greg KH wrote: > On Mon, Aug 11, 2014 at 03:32:48PM +0100, Stefano Stabellini wrote: > > CC'ing tty maintainers. > > Why? Is that how you submit a patch to be included to the kernel tree? > (hint, the answer is no, and also you should cc: the linux-serial > list...) Sorry, I resent it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index 636c9ba..b8491f5 100644 --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -402,9 +402,6 @@ static int xencons_connect_backend(struct xenbus_device *dev, evtchn); if (ret) goto error_xenbus; - ret = xenbus_printf(xbt, dev->nodename, "type", "ioemu"); - if (ret) - goto error_xenbus; ret = xenbus_transaction_end(xbt, 0); if (ret) { if (ret == -EAGAIN)
The backend type is chosen by the toolstack. Regardless, the frontend should not care, especially given that it cannot have an effect as the backend is started before this code is run. Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/