| Message ID | 1609240776-39726-1-git-send-email-tiantao6@hisilicon.com |
|---|---|
| State | New |
| Headers | show |
| Series | watchdog: use boolean value when setting nowayout | expand |
On 12/29/20 3:19 AM, Tian Tao wrote: > Fixes coccicheck warnings: > drivers/watchdog/alim7101_wdt.c:390:2-10: WARNING: Assignment of 0/1 to > bool variable > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > drivers/watchdog/alim7101_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c > index 4ff7f5a..951449e 100644 > --- a/drivers/watchdog/alim7101_wdt.c > +++ b/drivers/watchdog/alim7101_wdt.c > @@ -387,7 +387,7 @@ static int __init alim7101_wdt_init(void) > pr_info("Detected old alim7101 revision 'a1d'. If this is a cobalt board, set the 'use_gpio' module parameter.\n"); > goto err_out; > } > - nowayout = 1; > + nowayout = true; > } else if ((tmp & 0x1e) != 0x12 && (tmp & 0x1e) != 0x00) { > pr_info("ALi 1543 South-Bridge does not have the correct revision number (???1001?) - WDT not set\n"); > goto err_out; > This driver would benefit from conversion to use the watchdog subsystem, but it doesn't benefit from cosmetic changes. For the record, I am not going to accept cosmetic changes to watchdog drivers unless they use the watchdog subsystem. As a general comment, please list the driver name in the subject of your patches. Thanks, Guenter
diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c index 4ff7f5a..951449e 100644 --- a/drivers/watchdog/alim7101_wdt.c +++ b/drivers/watchdog/alim7101_wdt.c @@ -387,7 +387,7 @@ static int __init alim7101_wdt_init(void) pr_info("Detected old alim7101 revision 'a1d'. If this is a cobalt board, set the 'use_gpio' module parameter.\n"); goto err_out; } - nowayout = 1; + nowayout = true; } else if ((tmp & 0x1e) != 0x12 && (tmp & 0x1e) != 0x00) { pr_info("ALi 1543 South-Bridge does not have the correct revision number (???1001?) - WDT not set\n"); goto err_out;
Fixes coccicheck warnings: drivers/watchdog/alim7101_wdt.c:390:2-10: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/watchdog/alim7101_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)