| Message ID | 20201230154624.714388-1-arnd@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: nomadik: remove an unused variable | expand |
On Wed, Dec 30, 2020 at 04:46:17PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > A recent patch added a local variable twice: > > drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable] > > Remove the unused outer declaration > > Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c > index d4ea10803fd9..abfe11c7b49f 100644 > --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c > +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c > @@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s, > } else { > int irq = chip->to_irq(chip, offset); > const int pullidx = pull ? 1 : 0; > - bool wake; > int val; > static const char * const pulls[] = { > "none ", > -- > 2.29.2 > Got rid of the warning for me, I don't have hardware to test on but I don't think that's necessary for this. Tested-by: Andrew Halaney <ajhalaney@gmail.com> Reviewed-by: Andrew Halaney <ajhalaney@gmail.com> Thanks, Andrew
On Wed, Dec 30, 2020 at 4:46 PM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > A recent patch added a local variable twice: > > drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable] > > Remove the unused outer declaration > > Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> I got an identical patch from Nathan Chancellor on dec 29 :D I'll add your reported-by and Andrews tags. Yours, Linus Walleij
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index d4ea10803fd9..abfe11c7b49f 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s, } else { int irq = chip->to_irq(chip, offset); const int pullidx = pull ? 1 : 0; - bool wake; int val; static const char * const pulls[] = { "none ",