diff mbox series

[2/7] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

Message ID 20210115200905.3470941-3-lee.jones@linaro.org
State Accepted
Commit 090c7ae8e0d0a983b59c8a96628dd698d2ca8e1e
Headers show
Series Rid W=1 warnings in Ethernet | expand

Commit Message

Lee Jones Jan. 15, 2021, 8:09 p.m. UTC 
Fixes the following W=1 kernel build warning(s):

 drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'dev' not described in 'frontend_changed'
 drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'frontend_state' not described in 'frontend_changed'
 drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'dev' not described in 'netback_probe'
 drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'id' not described in 'netback_probe'

Cc: Wei Liu <wei.liu@kernel.org>
Cc: Paul Durrant <paul@xen.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: xen-devel@lists.xenproject.org
Cc: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/net/xen-netback/xenbus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1

Comments

Paul Durrant Jan. 18, 2021, 10:35 a.m. UTC | #1 
> -----Original Message-----

> From: Lee Jones <lee.jones@linaro.org>

> Sent: 15 January 2021 20:09

> To: lee.jones@linaro.org

> Cc: linux-kernel@vger.kernel.org; Wei Liu <wei.liu@kernel.org>; Paul Durrant <paul@xen.org>; David S.

> Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Alexei Starovoitov <ast@kernel.org>;

> Daniel Borkmann <daniel@iogearbox.net>; Jesper Dangaard Brouer <hawk@kernel.org>; John Fastabend

> <john.fastabend@gmail.com>; Rusty Russell <rusty@rustcorp.com.au>; xen-devel@lists.xenproject.org;

> netdev@vger.kernel.org; bpf@vger.kernel.org; Andrew Lunn <andrew@lunn.ch>

> Subject: [PATCH 2/7] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

> 

> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'dev' not described in

> 'frontend_changed'

>  drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'frontend_state' not

> described in 'frontend_changed'

>  drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'dev' not described in

> 'netback_probe'

>  drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'id' not described in

> 'netback_probe'

> 

> Cc: Wei Liu <wei.liu@kernel.org>

> Cc: Paul Durrant <paul@xen.org>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: Jakub Kicinski <kuba@kernel.org>

> Cc: Alexei Starovoitov <ast@kernel.org>

> Cc: Daniel Borkmann <daniel@iogearbox.net>

> Cc: Jesper Dangaard Brouer <hawk@kernel.org>

> Cc: John Fastabend <john.fastabend@gmail.com>

> Cc: Rusty Russell <rusty@rustcorp.com.au>

> Cc: xen-devel@lists.xenproject.org

> Cc: netdev@vger.kernel.org

> Cc: bpf@vger.kernel.org

> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Reviewed-by: Paul Durrant <paul@xen.org>
diff mbox series

Patch

diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index 6f10e0998f1ce..a5439c130130f 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -411,7 +411,7 @@  static void read_xenbus_frontend_xdp(struct backend_info *be,
 	vif->xdp_headroom = headroom;
 }
 
-/**
+/*
  * Callback received when the frontend's state changes.
  */
 static void frontend_changed(struct xenbus_device *dev,
@@ -996,7 +996,7 @@  static int netback_remove(struct xenbus_device *dev)
 	return 0;
 }
 
-/**
+/*
  * Entry point to this code when a new device is created.  Allocate the basic
  * structures and switch to InitWait.
  */