| Message ID | 20210128082847.2205950-1-geert+renesas@glider.be |
|---|---|
| State | Accepted |
| Commit | 2dfc564bda4a31bc4439315448bd4da5182cb397 |
| Headers | show |
| Series | [v2] soc: renesas: rcar-sysc: Mark device node OF_POPULATED after init | expand |
diff --git a/drivers/soc/renesas/rcar-sysc.c b/drivers/soc/renesas/rcar-sysc.c index d51ddc7d5232b9db..53387a72ca00ce79 100644 --- a/drivers/soc/renesas/rcar-sysc.c +++ b/drivers/soc/renesas/rcar-sysc.c @@ -434,6 +434,8 @@ static int __init rcar_sysc_pd_init(void) } error = of_genpd_add_provider_onecell(np, &domains->onecell_data); + if (!error) + of_node_set_flag(np, OF_POPULATED); out_put: of_node_put(np);
The R-Car System Controller (SYSC) driver registers PM domains from an early_initcall(). It does not use a platform driver, as secondary CPU startup on R-Car H1 needs to control the CPU power domains, before initialization of the driver framework. As fw_devlink only considers devices, it does not know that the System Controller is ready. Hence probing of on-chip devices that are part of the SYSC PM domain fails if fw_devlink is enabled: probe deferral - supplier e6180000.system-controller not ready Fix this by setting the OF_POPULATED flag for the SYSC device node after successful initialization. This will make of_link_to_phandle() ignore the SYSC device node as a dependency, and consumer devices will be probed again. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Saravana Kannan <saravanak@google.com> --- As this seems to be harmless if commit e590474768f1cc04 ("driver core: Set fw_devlink=on by default") won't make v5.12, I plan to queue this in renesas-devel for v5.12. v2: - Add Reviewed-by, - s/platform devices/devices/, - Drop Fixes tag, - Drop RFC. --- drivers/soc/renesas/rcar-sysc.c | 2 ++ 1 file changed, 2 insertions(+)