| Message ID | 0877601216922E4B83A7129715B5DA2BAC6EE226C5@GEORGE.Emea.Arm.com |
|---|---|
| State | New |
| Headers | show |
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com> > -----Original Message----- > From: Olivier Martin [mailto:Olivier.Martin@arm.com] > Sent: Tuesday, September 16, 2014 9:53 AM > To: Carsey, Jaben; edk2-devel@lists.sourceforge.net > Cc: Harry Liebel > Subject: RE: [edk2] [PATCH] ShellPkg: Specify AArch64 intrinsics library > Importance: High > > You are right. Please find the new version of the patch that should do the > right thing. > ________________________________________ > From: Carsey, Jaben [jaben.carsey@intel.com] > Sent: 21 August 2014 23:06 > To: Olivier Martin; edk2-devel@lists.sourceforge.net > Cc: Harry Liebel; Carsey, Jaben > Subject: RE: [edk2] [PATCH] ShellPkg: Specify AArch64 intrinsics library > > But your patch does not include adding the [AARCH64] section, just the line > within that section. > > > > -----Original Message----- > > From: Olivier Martin [mailto:Olivier.Martin@arm.com] > > Sent: Thursday, August 21, 2014 1:55 PM > > To: Carsey, Jaben; edk2-devel@lists.sourceforge.net > > Cc: Harry Liebel > > Subject: RE: [edk2] [PATCH] ShellPkg: Specify AArch64 intrinsics > > library > > Importance: High > > > > I guess you are missing AArch64. You are mixing with ARM. > > > > The patch does: > > [LibraryClasses.AARCH64] > > + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf > > > > ________________________________________ > > From: Carsey, Jaben [jaben.carsey@intel.com] > > Sent: 21 August 2014 21:32 > > To: Olivier Martin; edk2-devel@lists.sourceforge.net > > Cc: Harry Liebel; Carsey, Jaben > > Subject: RE: [edk2] [PATCH] ShellPkg: Specify AArch64 intrinsics > > library > > > > This appears identical to the change made in 2011 by Andrew fish. Am > > I missing something? I see that line in the DSC already. > > > > The library under it (AArch64Lib.inf) does not appear in the tip > > though... not sure what happened. > > > > -Jaben > > > > From: Olivier Martin [mailto:olivier.martin@arm.com] > > Sent: Thursday, August 21, 2014 6:12 AM > > To: edk2-devel@lists.sourceforge.net; Carsey, Jaben > > Cc: Harry Liebel > > Subject: RE: [edk2] [PATCH] ShellPkg: Specify AArch64 intrinsics > > library > > Importance: High > > > > ... with the patch > > > > From: Olivier Martin [mailto:olivier.martin@arm.com] > > Sent: 21 August 2014 12:01 > > To: Carsey, Jaben > > Cc: edk2-devel@lists.sourceforge.net<mailto:edk2- > > devel@lists.sourceforge.net>; Harry Liebel > > Subject: [edk2] [PATCH] ShellPkg: Specify AArch64 intrinsics library > > > > Dear ShellPkg maintainer, > > > > Please find the attached patch that adds the CompilerIntrinsics for > AARCH64. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Harry Liebel > > <Harry.Liebel@arm.com<mailto:Harry.Liebel@arm.com>> > > Reviewed-By: Olivier Martin > > <olivier.martin@arm.com<mailto:olivier.martin@arm.com>> > > Regards, > > Olivier > > > > -- IMPORTANT NOTICE: The contents of this email and any attachments > > are confidential and may also be privileged. If you are not the > > intended recipient, please notify the sender immediately and do not > > disclose the contents to any other person, use it for any purpose, or > > store or copy the information in any medium. Thank you. > > > > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > > Registered in England & Wales, Company No: 2557590 ARM Holdings plc, > > Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in > > England & Wales, Company No: 2548782 > > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended recipient, > please notify the sender immediately and do not disclose the contents to any > other person, use it for any purpose, or store or copy the information in any > medium. Thank you. > > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2557590 ARM Holdings plc, > Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in > England & Wales, Company No: 2548782 ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce. Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
From 14b57538dc73095457046c311b7a221f36b4ad14 Mon Sep 17 00:00:00 2001 From: Harry Liebel <Harry.Liebel@arm.com> Date: Mon, 14 Jul 2014 16:01:33 +0100 Subject: ShellPkg: Specify AArch64 intrinsics library Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Harry Liebel <Harry.Liebel@arm.com> Reviewed-By: Olivier Martin <olivier.martin@arm.com> --- ShellPkg/ShellPkg.dsc | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index 19898b1..20eb034 100644 --- a/ShellPkg/ShellPkg.dsc +++ b/ShellPkg/ShellPkg.dsc @@ -59,6 +59,9 @@ # NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf +[LibraryClasses.AARCH64] + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf + [PcdsFixedAtBuild] gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE -- 1.7.5.4