diff mbox

[v2,3/6] of: Don't try to search when phandle == 0

Message ID 1412454602-28518-3-git-send-email-grant.likely@linaro.org
State Accepted
Commit fc59b4479c172e413df615cea1635247265e07a0
Headers show

Commit Message

Grant Likely Oct. 4, 2014, 8:29 p.m. UTC 
A value of '0' isn't a valid phandle, so searching for a node with that
phandle is pointless. It will result in nothing but false positives.

Signed-off-by: Grant Likely <grant.likely@linaro.org>
---
 drivers/of/base.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox

Patch

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 293ed4b687ba..2305dc0382bc 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1021,6 +1021,9 @@  struct device_node *of_find_node_by_phandle(phandle handle)
 	struct device_node *np;
 	unsigned long flags;
 
+	if (!handle)
+		return NULL;
+
 	raw_spin_lock_irqsave(&devtree_lock, flags);
 	for (np = of_allnodes; np; np = np->allnext)
 		if (np->phandle == handle)