diff mbox

[v4,09/10] ARM: dts: am33xx: Update DCAN nodes

Message ID 1415881371-4982-10-git-send-email-rogerq@ti.com
State Accepted
Commit e23aabc6e607dfc49ba22855264e78abef1fda34
Headers show

Commit Message

Roger Quadros Nov. 13, 2014, 12:22 p.m. UTC
Add "raminit-syscon" property to specify the RAMINIT register.
Add clock information.
Rename can nodes from "d_can" to "can" to be compliant
with the ePAPR specs.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/am33xx.dtsi | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

Comments

Wolfram Sang Nov. 13, 2014, 4:03 p.m. UTC | #1
On Thu, Nov 13, 2014 at 02:22:50PM +0200, Roger Quadros wrote:
> Add "raminit-syscon" property to specify the RAMINIT register.
> Add clock information.
> Rename can nodes from "d_can" to "can" to be compliant
> with the ePAPR specs.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/boot/dts/am33xx.dtsi | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 9f3058c..74fefa1 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -338,20 +338,24 @@
>  			interrupts = <91>;
>  		};
>  
> -		dcan0: d_can@481cc000 {
> -			compatible = "bosch,d_can";
> +		dcan0: can@481cc000 {
> +			compatible = "ti,am3352-d_can";
>  			ti,hwmods = "d_can0";
> -			reg = <0x481cc000 0x2000
> -				0x44e10644 0x4>;
> +			reg = <0x481cc000 0x2000>;
> +			clocks = <&dcan0_fck>;
> +			clock-names = "fck";
> +			syscon-raminit = <&am33xx_control_module 0x644 0>;

Yeah, I missed to write the mail that I disagreed with the "dcan_0/1"
compatible-properties of V3. The second parameter to syscon here is much
better!

Acked-by: Wolfram Sang <wsa@the-dreams.de>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9f3058c..74fefa1 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -338,20 +338,24 @@ 
 			interrupts = <91>;
 		};
 
-		dcan0: d_can@481cc000 {
-			compatible = "bosch,d_can";
+		dcan0: can@481cc000 {
+			compatible = "ti,am3352-d_can";
 			ti,hwmods = "d_can0";
-			reg = <0x481cc000 0x2000
-				0x44e10644 0x4>;
+			reg = <0x481cc000 0x2000>;
+			clocks = <&dcan0_fck>;
+			clock-names = "fck";
+			syscon-raminit = <&am33xx_control_module 0x644 0>;
 			interrupts = <52>;
 			status = "disabled";
 		};
 
-		dcan1: d_can@481d0000 {
-			compatible = "bosch,d_can";
+		dcan1: can@481d0000 {
+			compatible = "ti,am3352-d_can";
 			ti,hwmods = "d_can1";
-			reg = <0x481d0000 0x2000
-				0x44e10644 0x4>;
+			reg = <0x481d0000 0x2000>;
+			clocks = <&dcan1_fck>;
+			clock-names = "fck";
+			syscon-raminit = <&am33xx_control_module 0x644 1>;
 			interrupts = <55>;
 			status = "disabled";
 		};