| Message ID | 1417544894-2000-2-git-send-email-eric.auger@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Tue, Dec 02, 2014 at 06:28:13PM +0000, Eric Auger wrote: > Syncup KVM related linux headers from linux-next tree using > scripts/update-linux-headers.sh. > > Add a new group/attribute in VGIC KVM device enabling to force > vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT > > Signed-off-by: Eric Auger <eric.auger@linaro.org> How can this be from linux-next? I'm pretty sure we didn't merge this patch yet. Also, if you synced your headers from your local tree, I think that generally makes such a QEMU patches series an RFC one. -Christoffer
On 12/03/2014 11:49 AM, Christoffer Dall wrote: > On Tue, Dec 02, 2014 at 06:28:13PM +0000, Eric Auger wrote: >> Syncup KVM related linux headers from linux-next tree using >> scripts/update-linux-headers.sh. >> >> Add a new group/attribute in VGIC KVM device enabling to force >> vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT >> >> Signed-off-by: Eric Auger <eric.auger@linaro.org> > > How can this be from linux-next? I'm pretty sure we didn't merge this > patch yet. Hi Christoffer, yes that's correct . I don't know how to format that kind of patch that refers to linux headers (I mentioned in the title tag ToBeFilled). I looked at other similar ones and I thought this was the wording that is generally used. I can move it to RFC but it will stay as is until kernel patches are upstreamed. In that case I should also move the QEMU VFIO patch back to RFC due to forwarding stuff;-) Best Regards Eric > > Also, if you synced your headers from your local tree, I think that > generally makes such a QEMU patches series an RFC one. > > -Christoffer >
On 12/03/2014 12:03 PM, Christoffer Dall wrote: > On Wed, Dec 03, 2014 at 11:53:58AM +0100, Eric Auger wrote: >> On 12/03/2014 11:49 AM, Christoffer Dall wrote: >>> On Tue, Dec 02, 2014 at 06:28:13PM +0000, Eric Auger wrote: >>>> Syncup KVM related linux headers from linux-next tree using >>>> scripts/update-linux-headers.sh. >>>> >>>> Add a new group/attribute in VGIC KVM device enabling to force >>>> vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT >>>> >>>> Signed-off-by: Eric Auger <eric.auger@linaro.org> >>> >>> How can this be from linux-next? I'm pretty sure we didn't merge this >>> patch yet. >> >> Hi Christoffer, >> >> yes that's correct . I don't know how to format that kind of patch that >> refers to linux headers (I mentioned in the title tag ToBeFilled). I >> looked at other similar ones and I thought this was the wording that is >> generally used. I can move it to RFC but it will stay as is until kernel >> patches are upstreamed. In that case I should also move the QEMU VFIO >> patch back to RFC due to forwarding stuff;-) >> > This patch subject should just be something like this: > > Subject: [RFC PATCH 1/2] linux-headers: Update KVM headers for KVM_DEV_ARM_VGIC_GRP_CTRL > > And in the commit message you point to a personal git tree that contains > the patches you're syncing against. OK thanks I will update accordingly Eric > > -Christoffer >
On Wed, Dec 03, 2014 at 11:53:58AM +0100, Eric Auger wrote: > On 12/03/2014 11:49 AM, Christoffer Dall wrote: > > On Tue, Dec 02, 2014 at 06:28:13PM +0000, Eric Auger wrote: > >> Syncup KVM related linux headers from linux-next tree using > >> scripts/update-linux-headers.sh. > >> > >> Add a new group/attribute in VGIC KVM device enabling to force > >> vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT > >> > >> Signed-off-by: Eric Auger <eric.auger@linaro.org> > > > > How can this be from linux-next? I'm pretty sure we didn't merge this > > patch yet. > > Hi Christoffer, > > yes that's correct . I don't know how to format that kind of patch that > refers to linux headers (I mentioned in the title tag ToBeFilled). I > looked at other similar ones and I thought this was the wording that is > generally used. I can move it to RFC but it will stay as is until kernel > patches are upstreamed. In that case I should also move the QEMU VFIO > patch back to RFC due to forwarding stuff;-) > This patch subject should just be something like this: Subject: [RFC PATCH 1/2] linux-headers: Update KVM headers for KVM_DEV_ARM_VGIC_GRP_CTRL And in the commit message you point to a personal git tree that contains the patches you're syncing against. -Christoffer
diff --git a/linux-headers/asm-arm/kvm.h b/linux-headers/asm-arm/kvm.h index 09ee408..0db25bc 100644 --- a/linux-headers/asm-arm/kvm.h +++ b/linux-headers/asm-arm/kvm.h @@ -175,6 +175,8 @@ struct kvm_arch_memory_slot { #define KVM_DEV_ARM_VGIC_OFFSET_SHIFT 0 #define KVM_DEV_ARM_VGIC_OFFSET_MASK (0xffffffffULL << KVM_DEV_ARM_VGIC_OFFSET_SHIFT) #define KVM_DEV_ARM_VGIC_GRP_NR_IRQS 3 +#define KVM_DEV_ARM_VGIC_GRP_CTRL 4 +#define KVM_DEV_ARM_VGIC_CTRL_INIT 0 /* KVM_IRQ_LINE irq field index values */ #define KVM_ARM_IRQ_TYPE_SHIFT 24 diff --git a/linux-headers/asm-arm64/kvm.h b/linux-headers/asm-arm64/kvm.h index 8e38878..cbce625 100644 --- a/linux-headers/asm-arm64/kvm.h +++ b/linux-headers/asm-arm64/kvm.h @@ -161,6 +161,8 @@ struct kvm_arch_memory_slot { #define KVM_DEV_ARM_VGIC_OFFSET_SHIFT 0 #define KVM_DEV_ARM_VGIC_OFFSET_MASK (0xffffffffULL << KVM_DEV_ARM_VGIC_OFFSET_SHIFT) #define KVM_DEV_ARM_VGIC_GRP_NR_IRQS 3 +#define KVM_DEV_ARM_VGIC_GRP_CTRL 4 +#define KVM_DEV_ARM_VGIC_CTRL_INIT 0 /* KVM_IRQ_LINE irq field index values */ #define KVM_ARM_IRQ_TYPE_SHIFT 24
Syncup KVM related linux headers from linux-next tree using scripts/update-linux-headers.sh. Add a new group/attribute in VGIC KVM device enabling to force vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT Signed-off-by: Eric Auger <eric.auger@linaro.org> --- linux-headers/asm-arm/kvm.h | 2 ++ linux-headers/asm-arm64/kvm.h | 2 ++ 2 files changed, 4 insertions(+)