diff mbox series

[10/11] mm/page_alloc: Update PGFREE outside the zone lock in __free_pages_ok

Message ID 20210414133931.4555-11-mgorman@techsingularity.net
State New
Headers show
Series Use local_lock for pcp protection and reduce stat overhead | expand

Commit Message

Mel Gorman April 14, 2021, 1:39 p.m. UTC 
VM events do not need explicit protection by disabling IRQs so
update the counter with IRQs enabled in __free_pages_ok.

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 mm/page_alloc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Vlastimil Babka April 15, 2021, 1:04 p.m. UTC | #1 
On 4/14/21 3:39 PM, Mel Gorman wrote:
> VM events do not need explicit protection by disabling IRQs so

> update the counter with IRQs enabled in __free_pages_ok.

> 

> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>


Acked-by: Vlastimil Babka <vbabka@suse.cz>


> ---

>  mm/page_alloc.c | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/mm/page_alloc.c b/mm/page_alloc.c

> index a0b210077178..8a94fe77bef7 100644

> --- a/mm/page_alloc.c

> +++ b/mm/page_alloc.c

> @@ -1569,10 +1569,11 @@ static void __free_pages_ok(struct page *page, unsigned int order,

>  	migratetype = get_pfnblock_migratetype(page, pfn);

>  

>  	spin_lock_irqsave(&zone->lock, flags);

> -	__count_vm_events(PGFREE, 1 << order);

>  	migratetype = check_migratetype_isolated(zone, page, pfn, migratetype);

>  	__free_one_page(page, pfn, zone, order, migratetype, fpi_flags);

>  	spin_unlock_irqrestore(&zone->lock, flags);

> +

> +	__count_vm_events(PGFREE, 1 << order);

>  }

>  

>  void __free_pages_core(struct page *page, unsigned int order)

>
diff mbox series

Patch

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index a0b210077178..8a94fe77bef7 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1569,10 +1569,11 @@  static void __free_pages_ok(struct page *page, unsigned int order,
 	migratetype = get_pfnblock_migratetype(page, pfn);
 
 	spin_lock_irqsave(&zone->lock, flags);
-	__count_vm_events(PGFREE, 1 << order);
 	migratetype = check_migratetype_isolated(zone, page, pfn, migratetype);
 	__free_one_page(page, pfn, zone, order, migratetype, fpi_flags);
 	spin_unlock_irqrestore(&zone->lock, flags);
+
+	__count_vm_events(PGFREE, 1 << order);
 }
 
 void __free_pages_core(struct page *page, unsigned int order)