| Message ID | fda981546203427a0ac86ef47f231239ad18ecfe.1618520227.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | Accepted |
| Commit | 204db365077df99a487bcd41aa8c6135f783be18 |
| Headers | show |
| Series | [1/2] Input: evbug - Remove an empty comment block | expand |
On Thu, 2021-04-15 at 22:58 +0200, Christophe JAILLET wrote: > 'printk(KERN_DEBUG pr_fmt(...))' can be replaced by a much less verbose > 'pr_debug()'. This is not really true because printk(KERN_DEBUG ...); will _always_ be emitted if the console level allows pr_debug(...); will _only_ be emitted if the console level allows _and_ DEBUG is defined or dynamic_debug is enabled (and for dynamic_debug, only if specifically enabled) DEBUG is defined and dynamic_debug is enabled > diff --git a/drivers/input/evbug.c b/drivers/input/evbug.c [] > @@ -21,8 +21,8 @@ MODULE_LICENSE("GPL"); > > > static void evbug_event(struct input_handle *handle, unsigned int type, unsigned int code, int value) > { > - printk(KERN_DEBUG pr_fmt("Event. Dev: %s, Type: %d, Code: %d, Value: %d\n"), > - dev_name(&handle->dev->dev), type, code, value); > + pr_debug("Event. Dev: %s, Type: %d, Code: %d, Value: %d\n", > + dev_name(&handle->dev->dev), type, code, value); > }
On Thu, Apr 15, 2021 at 10:58:16PM +0200, Christophe JAILLET wrote: > This is a left-over from commit 1a59d1b8e05e ("treewide: Replace GPLv2 > boilerplate/reference with SPDX - rule 156") > > Axe an empty and useless comment block. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied, thank you. -- Dmitry
diff --git a/drivers/input/evbug.c b/drivers/input/evbug.c index c0d0b121ae7e..e47bdf92088a 100644 --- a/drivers/input/evbug.c +++ b/drivers/input/evbug.c @@ -7,9 +7,6 @@ * Input driver event debug module - dumps all events into syslog */ -/* - */ - #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include <linux/slab.h>
This is a left-over from commit 1a59d1b8e05e ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156") Axe an empty and useless comment block. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/input/evbug.c | 3 --- 1 file changed, 3 deletions(-)