| Message ID | 1619416452-6852-1-git-send-email-rnayak@codeaurora.org |
|---|---|
| State | Accepted |
| Commit | c813bb37bd32cb967060a2c573fae4ea518d32eb |
| Headers | show |
| Series | [v2] nvmem: qfprom: minor nit fixes | expand |
Hi, On Sun, Apr 25, 2021 at 10:54 PM Rajendra Nayak <rnayak@codeaurora.org> wrote: > > Fix a missed newline, change an 'if' to 'else if' and update > a comment which is stale after the merge of '5a1bea2a: nvmem: > qfprom: Add support for fuseblowing on sc7280' > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> > --- > v2: Added the change to move the 'if' to 'else if' > Sending a follow-up patch for these nits since they came in after > the previous patch was already pulled in > https://lore.kernel.org/patchwork/patch/1401964/ > > drivers/nvmem/qfprom.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c > index d6d3f24..1ba666b 100644 > --- a/drivers/nvmem/qfprom.c > +++ b/drivers/nvmem/qfprom.c > @@ -122,6 +122,7 @@ static const struct qfprom_soc_compatible_data sc7280_qfprom = { > .keepout = sc7280_qfprom_keepout, > .nkeepout = ARRAY_SIZE(sc7280_qfprom_keepout) > }; > + > /** > * qfprom_disable_fuse_blowing() - Undo enabling of fuse blowing. > * @priv: Our driver data. > @@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv, > } > > /* > - * Hardware requires 1.8V min for fuse blowing; this may be > + * Hardware requires a min voltage for fuse blowing; this may be > * a rail shared do don't specify a max--regulator constraints Joe pointed out a typo in the original comment that "do" should be "so" [1], but that's not new to your patch so: Reviewed-by: Douglas Anderson <dianders@chromium.org> [1] https://lore.kernel.org/r/73945e7037ab61eb34a2a1af05aa3eef75c8f836.camel@perches.com
On 26/04/2021 06:54, Rajendra Nayak wrote: > Fix a missed newline, change an 'if' to 'else if' and update > a comment which is stale after the merge of '5a1bea2a: nvmem: > qfprom: Add support for fuseblowing on sc7280' > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> Applied thanks, --srini > --- > v2: Added the change to move the 'if' to 'else if' > Sending a follow-up patch for these nits since they came in after > the previous patch was already pulled in > https://lore.kernel.org/patchwork/patch/1401964/ > > drivers/nvmem/qfprom.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c > index d6d3f24..1ba666b 100644 > --- a/drivers/nvmem/qfprom.c > +++ b/drivers/nvmem/qfprom.c > @@ -122,6 +122,7 @@ static const struct qfprom_soc_compatible_data sc7280_qfprom = { > .keepout = sc7280_qfprom_keepout, > .nkeepout = ARRAY_SIZE(sc7280_qfprom_keepout) > }; > + > /** > * qfprom_disable_fuse_blowing() - Undo enabling of fuse blowing. > * @priv: Our driver data. > @@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv, > } > > /* > - * Hardware requires 1.8V min for fuse blowing; this may be > + * Hardware requires a min voltage for fuse blowing; this may be > * a rail shared do don't specify a max--regulator constraints > * will handle. > */ > @@ -399,7 +400,7 @@ static int qfprom_probe(struct platform_device *pdev) > > if (major_version == 7 && minor_version == 8) > priv->soc_data = &qfprom_7_8_data; > - if (major_version == 7 && minor_version == 15) > + else if (major_version == 7 && minor_version == 15) > priv->soc_data = &qfprom_7_15_data; > > priv->vcc = devm_regulator_get(&pdev->dev, "vcc"); >
diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index d6d3f24..1ba666b 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -122,6 +122,7 @@ static const struct qfprom_soc_compatible_data sc7280_qfprom = { .keepout = sc7280_qfprom_keepout, .nkeepout = ARRAY_SIZE(sc7280_qfprom_keepout) }; + /** * qfprom_disable_fuse_blowing() - Undo enabling of fuse blowing. * @priv: Our driver data. @@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv, } /* - * Hardware requires 1.8V min for fuse blowing; this may be + * Hardware requires a min voltage for fuse blowing; this may be * a rail shared do don't specify a max--regulator constraints * will handle. */ @@ -399,7 +400,7 @@ static int qfprom_probe(struct platform_device *pdev) if (major_version == 7 && minor_version == 8) priv->soc_data = &qfprom_7_8_data; - if (major_version == 7 && minor_version == 15) + else if (major_version == 7 && minor_version == 15) priv->soc_data = &qfprom_7_15_data; priv->vcc = devm_regulator_get(&pdev->dev, "vcc");
Fix a missed newline, change an 'if' to 'else if' and update a comment which is stale after the merge of '5a1bea2a: nvmem: qfprom: Add support for fuseblowing on sc7280' Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> --- v2: Added the change to move the 'if' to 'else if' Sending a follow-up patch for these nits since they came in after the previous patch was already pulled in https://lore.kernel.org/patchwork/patch/1401964/ drivers/nvmem/qfprom.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)