| Message ID | 2c52c48533f6eafdb7b9c72ee2f02747e851a983.1619621413.git.mchehab+huawei@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Address some issues with PM runtime at media subsystem | expand |
On 28.04.2021 16:51, Mauro Carvalho Chehab wrote: > There's a bug at s5p_cec_adap_enable(): if called to > disable the device, it should call pm_runtime_put() > instead of pm_runtime_disable(), as the goal here is to > decrement the usage_count and not to disable PM runtime. > > Reported-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Fixes: 1bcbf6f4b6b0 ("[media] cec: s5p-cec: Add s5p-cec driver") > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Thanks, Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> There is a typo in the subject, s6p_cec -> s5p_cec. > --- > drivers/media/cec/platform/s5p/s5p_cec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/cec/platform/s5p/s5p_cec.c b/drivers/media/cec/platform/s5p/s5p_cec.c > index 2a3e7ffefe0a..3c7c4c3c798c 100644 > --- a/drivers/media/cec/platform/s5p/s5p_cec.c > +++ b/drivers/media/cec/platform/s5p/s5p_cec.c > @@ -51,7 +51,7 @@ static int s5p_cec_adap_enable(struct cec_adapter *adap, bool enable) > } else { > s5p_cec_mask_tx_interrupts(cec); > s5p_cec_mask_rx_interrupts(cec); > - pm_runtime_disable(cec->dev); > + pm_runtime_put(cec->dev); > } > > return 0;
diff --git a/drivers/media/cec/platform/s5p/s5p_cec.c b/drivers/media/cec/platform/s5p/s5p_cec.c index 2a3e7ffefe0a..3c7c4c3c798c 100644 --- a/drivers/media/cec/platform/s5p/s5p_cec.c +++ b/drivers/media/cec/platform/s5p/s5p_cec.c @@ -51,7 +51,7 @@ static int s5p_cec_adap_enable(struct cec_adapter *adap, bool enable) } else { s5p_cec_mask_tx_interrupts(cec); s5p_cec_mask_rx_interrupts(cec); - pm_runtime_disable(cec->dev); + pm_runtime_put(cec->dev); } return 0;
There's a bug at s5p_cec_adap_enable(): if called to disable the device, it should call pm_runtime_put() instead of pm_runtime_disable(), as the goal here is to decrement the usage_count and not to disable PM runtime. Reported-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Fixes: 1bcbf6f4b6b0 ("[media] cec: s5p-cec: Add s5p-cec driver") Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- drivers/media/cec/platform/s5p/s5p_cec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)