| Message ID | 20210429003751.224232-1-bjorn.andersson@linaro.org |
|---|---|
| State | Accepted |
| Commit | 969ef42b1ae094da99b8acbf14864f94d37f6e58 |
| Headers | show |
| Series | pinctrl: qcom: spmi-mpp: Add compatible for pmi8994 | expand |
On Wed, 28 Apr 2021 17:37:51 -0700, Bjorn Andersson wrote: > The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware > block to the MPP driver. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > > PS. I see that while the related gpio driver was converted to hierarchical IRQ > chips the mpp driver didn't get the same treatment. We should fix this at some > point... > > Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 1 + > drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 + > 2 files changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, Apr 29, 2021 at 2:37 AM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware > block to the MPP driver. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Patch applied! > PS. I see that while the related gpio driver was converted to hierarchical IRQ > chips the mpp driver didn't get the same treatment. We should fix this at some > point... Oooups. I think Brian & I discussed that and that we "take GPIO first" or so, and then forgot step 2. It should pretty much be a copy/paste operation of the gitlog of what Brian did with the GPIO driver. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt index 0ba07bc96c55..5363d44cbb74 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt @@ -21,6 +21,7 @@ of PMIC's from Qualcomm. "qcom,pmi8950-mpp", "qcom,pm8994-mpp", "qcom,pma8084-mpp", + "qcom,pmi8994-mpp", And must contain either "qcom,spmi-mpp" or "qcom,ssbi-mpp" if the device is on an spmi bus or an ssbi bus respectively. diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c index 3c213f799feb..2da9b5f68f3f 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c @@ -920,6 +920,7 @@ static const struct of_device_id pmic_mpp_of_match[] = { { .compatible = "qcom,pmi8950-mpp" }, /* 4 MPP's */ { .compatible = "qcom,pm8994-mpp" }, /* 8 MPP's */ { .compatible = "qcom,pma8084-mpp" }, /* 8 MPP's */ + { .compatible = "qcom,pmi8994-mpp" }, /* 4 MPP's */ { .compatible = "qcom,spmi-mpp" }, /* Generic */ { }, };
The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware block to the MPP driver. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- PS. I see that while the related gpio driver was converted to hierarchical IRQ chips the mpp driver didn't get the same treatment. We should fix this at some point... Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 1 + drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 + 2 files changed, 2 insertions(+) -- 2.29.2