| Message ID | 20210507004047.4454-3-chris.packham@alliedtelesis.co.nz |
|---|---|
| State | Superseded |
| Headers | show |
| Series | P2040/P2041 i2c recovery erratum | expand |
On Fri, 2021-05-07 at 12:40 +1200, Chris Packham wrote: > The i2c controllers on the P2040/P2041 have an erratum where the > documented scheme for i2c bus recovery will not work (A-004447). A > different mechanism is needed which is documented in the P2040 Chip > Errata Rev Q (latest available at the time of writing). From what I can tell this Erratum also applies to P1010 Jocke
On Fri, 2021-05-07 at 10:04 +0200, Joakim Tjernlund wrote: > On Fri, 2021-05-07 at 12:40 +1200, Chris Packham wrote: > > The i2c controllers on the P2040/P2041 have an erratum where the > > documented scheme for i2c bus recovery will not work (A-004447). A > > different mechanism is needed which is documented in the P2040 Chip > > Errata Rev Q (latest available at the time of writing). > > From what I can tell this Erratum also applies to P1010 > > Jocke Reference: https://media.digikey.com/pdf/PCNs/Freescale/P1010CE_RevL.pdf Also, I think this series should go to stable. Jocke
On 7/05/21 8:24 pm, Joakim Tjernlund wrote: > On Fri, 2021-05-07 at 10:04 +0200, Joakim Tjernlund wrote: >> On Fri, 2021-05-07 at 12:40 +1200, Chris Packham wrote: >>> The i2c controllers on the P2040/P2041 have an erratum where the >>> documented scheme for i2c bus recovery will not work (A-004447). A >>> different mechanism is needed which is documented in the P2040 Chip >>> Errata Rev Q (latest available at the time of writing). >> From what I can tell this Erratum also applies to P1010 Will add for v3. >> Jocke > Reference: https://media.digikey.com/pdf/PCNs/Freescale/P1010CE_RevL.pdf > > Also, I think this series should go to stable. This series builds on changes that have been merged for v5.13. I haven't checked if it applies to stable, I think at least commit 65171b2df15e ("i2c: mpc: Make use of i2c_recover_bus()") would need to come along with it.
diff --git a/arch/powerpc/boot/dts/fsl/p2041si-post.dtsi b/arch/powerpc/boot/dts/fsl/p2041si-post.dtsi index 872e4485dc3f..ddc018d42252 100644 --- a/arch/powerpc/boot/dts/fsl/p2041si-post.dtsi +++ b/arch/powerpc/boot/dts/fsl/p2041si-post.dtsi @@ -371,7 +371,23 @@ sdhc@114000 { }; /include/ "qoriq-i2c-0.dtsi" + i2c@118000 { + fsl,i2c-erratum-a004447; + }; + + i2c@118100 { + fsl,i2c-erratum-a004447; + }; + /include/ "qoriq-i2c-1.dtsi" + i2c@119000 { + fsl,i2c-erratum-a004447; + }; + + i2c@119100 { + fsl,i2c-erratum-a004447; + }; + /include/ "qoriq-duart-0.dtsi" /include/ "qoriq-duart-1.dtsi" /include/ "qoriq-gpio-0.dtsi"
The i2c controllers on the P2040/P2041 have an erratum where the documented scheme for i2c bus recovery will not work (A-004447). A different mechanism is needed which is documented in the P2040 Chip Errata Rev Q (latest available at the time of writing). Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- arch/powerpc/boot/dts/fsl/p2041si-post.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)