diff mbox series

[RFC,v9,10/19] virtio/vsock: defines and constants for SEQPACKET

Message ID 20210508163508.3431890-1-arseny.krasnov@kaspersky.com
State Superseded
Headers show
Series virtio/vsock: introduce SOCK_SEQPACKET support | expand

Commit Message

Arseny Krasnov May 8, 2021, 4:35 p.m. UTC
This adds set of defines and constants for SOCK_SEQPACKET
support in vsock. Here is link to spec patch, which uses it:

https://lists.oasis-open.org/archives/virtio-comment/202103/msg00069.html

Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
---
 include/uapi/linux/virtio_vsock.h | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Stefano Garzarella May 13, 2021, 11:45 a.m. UTC | #1
On Sat, May 08, 2021 at 07:35:05PM +0300, Arseny Krasnov wrote:
>This adds set of defines and constants for SOCK_SEQPACKET

>support in vsock. Here is link to spec patch, which uses it:

>

>https://lists.oasis-open.org/archives/virtio-comment/202103/msg00069.html


Will you be submitting a new version?

>

>Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>

>---

> include/uapi/linux/virtio_vsock.h | 9 +++++++++

> 1 file changed, 9 insertions(+)

>

>diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h

>index 1d57ed3d84d2..3dd3555b2740 100644

>--- a/include/uapi/linux/virtio_vsock.h

>+++ b/include/uapi/linux/virtio_vsock.h

>@@ -38,6 +38,9 @@

> #include <linux/virtio_ids.h>

> #include <linux/virtio_config.h>

>

>+/* The feature bitmap for virtio vsock */

>+#define VIRTIO_VSOCK_F_SEQPACKET	1	/* SOCK_SEQPACKET supported */

>+

> struct virtio_vsock_config {

> 	__le64 guest_cid;

> } __attribute__((packed));

>@@ -65,6 +68,7 @@ struct virtio_vsock_hdr {

>

> enum virtio_vsock_type {

> 	VIRTIO_VSOCK_TYPE_STREAM = 1,

>+	VIRTIO_VSOCK_TYPE_SEQPACKET = 2,

> };

>

> enum virtio_vsock_op {

>@@ -91,4 +95,9 @@ enum virtio_vsock_shutdown {

> 	VIRTIO_VSOCK_SHUTDOWN_SEND = 2,

> };

>

>+/* VIRTIO_VSOCK_OP_RW flags values */

>+enum virtio_vsock_rw {

>+	VIRTIO_VSOCK_SEQ_EOR = 1,

>+};

>+

> #endif /* _UAPI_LINUX_VIRTIO_VSOCK_H */

>-- 

>2.25.1

>


Looks good:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Arseny Krasnov May 13, 2021, 2:42 p.m. UTC | #2
On 13.05.2021 14:45, Stefano Garzarella wrote:
> On Sat, May 08, 2021 at 07:35:05PM +0300, Arseny Krasnov wrote:

>> This adds set of defines and constants for SOCK_SEQPACKET

>> support in vsock. Here is link to spec patch, which uses it:

>>

>> https://lists.oasis-open.org/archives/virtio-comment/202103/msg00069.html

> Will you be submitting a new version?

Yes, i'll send new patch to spec in next few days.
>

>> Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>

>> ---

>> include/uapi/linux/virtio_vsock.h | 9 +++++++++

>> 1 file changed, 9 insertions(+)

>>

>> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h

>> index 1d57ed3d84d2..3dd3555b2740 100644

>> --- a/include/uapi/linux/virtio_vsock.h

>> +++ b/include/uapi/linux/virtio_vsock.h

>> @@ -38,6 +38,9 @@

>> #include <linux/virtio_ids.h>

>> #include <linux/virtio_config.h>

>>

>> +/* The feature bitmap for virtio vsock */

>> +#define VIRTIO_VSOCK_F_SEQPACKET	1	/* SOCK_SEQPACKET supported */

>> +

>> struct virtio_vsock_config {

>> 	__le64 guest_cid;

>> } __attribute__((packed));

>> @@ -65,6 +68,7 @@ struct virtio_vsock_hdr {

>>

>> enum virtio_vsock_type {

>> 	VIRTIO_VSOCK_TYPE_STREAM = 1,

>> +	VIRTIO_VSOCK_TYPE_SEQPACKET = 2,

>> };

>>

>> enum virtio_vsock_op {

>> @@ -91,4 +95,9 @@ enum virtio_vsock_shutdown {

>> 	VIRTIO_VSOCK_SHUTDOWN_SEND = 2,

>> };

>>

>> +/* VIRTIO_VSOCK_OP_RW flags values */

>> +enum virtio_vsock_rw {

>> +	VIRTIO_VSOCK_SEQ_EOR = 1,

>> +};

>> +

>> #endif /* _UAPI_LINUX_VIRTIO_VSOCK_H */

>> -- 

>> 2.25.1

>>

> Looks good:

>

> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>

>
diff mbox series

Patch

diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h
index 1d57ed3d84d2..3dd3555b2740 100644
--- a/include/uapi/linux/virtio_vsock.h
+++ b/include/uapi/linux/virtio_vsock.h
@@ -38,6 +38,9 @@ 
 #include <linux/virtio_ids.h>
 #include <linux/virtio_config.h>
 
+/* The feature bitmap for virtio vsock */
+#define VIRTIO_VSOCK_F_SEQPACKET	1	/* SOCK_SEQPACKET supported */
+
 struct virtio_vsock_config {
 	__le64 guest_cid;
 } __attribute__((packed));
@@ -65,6 +68,7 @@  struct virtio_vsock_hdr {
 
 enum virtio_vsock_type {
 	VIRTIO_VSOCK_TYPE_STREAM = 1,
+	VIRTIO_VSOCK_TYPE_SEQPACKET = 2,
 };
 
 enum virtio_vsock_op {
@@ -91,4 +95,9 @@  enum virtio_vsock_shutdown {
 	VIRTIO_VSOCK_SHUTDOWN_SEND = 2,
 };
 
+/* VIRTIO_VSOCK_OP_RW flags values */
+enum virtio_vsock_rw {
+	VIRTIO_VSOCK_SEQ_EOR = 1,
+};
+
 #endif /* _UAPI_LINUX_VIRTIO_VSOCK_H */