| Message ID | 20210511085126.4287-1-thunder.leizhen@huawei.com |
|---|---|
| State | Accepted |
| Commit | ef9385fbf30e9484e4291db76e000b8961419782 |
| Headers | show |
| Series | [1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe() | expand |
On 5/11/2021 1:51 AM, Zhen Lei wrote: > When devm_ioremap_resource() fails, a clear enough error message will be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly resource > information. > > Therefore, remove the error printing here to simplify code and reduce the > binary size. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c > index e2bd2dce6bb4154..dc511b9a6b43f1b 100644 > --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c > +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c > @@ -813,10 +813,8 @@ static int iproc_gpio_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > if (res) { > chip->io_ctrl = devm_ioremap_resource(dev, res); > - if (IS_ERR(chip->io_ctrl)) { > - dev_err(dev, "unable to map I/O memory\n"); > + if (IS_ERR(chip->io_ctrl)) > return PTR_ERR(chip->io_ctrl); > - } > if (of_device_is_compatible(dev->of_node, > "brcm,cygnus-ccm-gpio")) > io_ctrl_type = IOCTRL_TYPE_CDRU; > Looks good to me. Thanks! Acked-by: Ray Jui <ray.jui@broadcom.com>
On Tue, May 11, 2021 at 10:51 AM Zhen Lei <thunder.leizhen@huawei.com> wrote: > When devm_ioremap_resource() fails, a clear enough error message will be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly resource > information. > > Therefore, remove the error printing here to simplify code and reduce the > binary size. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c index e2bd2dce6bb4154..dc511b9a6b43f1b 100644 --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c @@ -813,10 +813,8 @@ static int iproc_gpio_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 1); if (res) { chip->io_ctrl = devm_ioremap_resource(dev, res); - if (IS_ERR(chip->io_ctrl)) { - dev_err(dev, "unable to map I/O memory\n"); + if (IS_ERR(chip->io_ctrl)) return PTR_ERR(chip->io_ctrl); - } if (of_device_is_compatible(dev->of_node, "brcm,cygnus-ccm-gpio")) io_ctrl_type = IOCTRL_TYPE_CDRU;
When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd