| Message ID | 20210515065830.7045-1-thunder.leizhen@huawei.com |
|---|---|
| State | Accepted |
| Commit | a6b1e7093f0a099571fc8836ab4a589633f956a8 |
| Headers | show |
| Series | [1/1] media: tc358743: Fix error return code in tc358743_probe_of() | expand |
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 1b309bb743c7bd7..f21da11caf22411 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1974,6 +1974,7 @@ static int tc358743_probe_of(struct tc358743_state *state) bps_pr_lane = 2 * endpoint.link_frequencies[0]; if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) { dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane); + ret = -EINVAL; goto disable_clk; }
When the CSI bps per lane is not in the valid range, an appropriate error code -EINVAL should be returned. However, we currently do not explicitly assign this error code to 'ret'. As a result, 0 was incorrectly returned. Fixes: 256148246852 ("[media] tc358743: support probe from device tree") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/media/i2c/tc358743.c | 1 + 1 file changed, 1 insertion(+) -- 2.26.0.106.g9fadedd