diff mbox series

gpio: gpio-regmap: Use devm_add_action_or_reset()

Message ID b0a7e849dbf7e92d2e32d8c751d87382b06f6547.1622714114.git.matti.vaittinen@fi.rohmeurope.com
State Accepted
Commit 40e568f9c88db8efe264b3a372faea940fc12a0f
Headers show
Series gpio: gpio-regmap: Use devm_add_action_or_reset() | expand

Commit Message

Vaittinen, Matti June 3, 2021, 10 a.m. UTC 
Slightly simplify the devm_gpio_regmap_register() by using the
devm_add_action_or_reset().

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Michael Walle <michael@walle.cc>
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
This patch was originally part of the series here:
https://lore.kernel.org/lkml/cover.1622008846.git.matti.vaittinen@fi.rohmeurope.com/

Other patches from the series were dropped.

 drivers/gpio/gpio-regmap.c | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

Comments

Bartosz Golaszewski June 4, 2021, 6:54 p.m. UTC | #1 
On Thu, Jun 3, 2021 at 12:00 PM Matti Vaittinen
<matti.vaittinen@fi.rohmeurope.com> wrote:
>

> Slightly simplify the devm_gpio_regmap_register() by using the

> devm_add_action_or_reset().

>

> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Reviewed-by: Michael Walle <michael@walle.cc>

> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

> ---


Applied, thanks!

Bartosz
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
index 134cedf151a7..1ead1290eb3f 100644
--- a/drivers/gpio/gpio-regmap.c
+++ b/drivers/gpio/gpio-regmap.c
@@ -311,9 +311,9 @@  void gpio_regmap_unregister(struct gpio_regmap *gpio)
 }
 EXPORT_SYMBOL_GPL(gpio_regmap_unregister);
 
-static void devm_gpio_regmap_unregister(struct device *dev, void *res)
+static void devm_gpio_regmap_unregister(void *res)
 {
-	gpio_regmap_unregister(*(struct gpio_regmap **)res);
+	gpio_regmap_unregister(res);
 }
 
 /**
@@ -330,20 +330,17 @@  static void devm_gpio_regmap_unregister(struct device *dev, void *res)
 struct gpio_regmap *devm_gpio_regmap_register(struct device *dev,
 					      const struct gpio_regmap_config *config)
 {
-	struct gpio_regmap **ptr, *gpio;
-
-	ptr = devres_alloc(devm_gpio_regmap_unregister, sizeof(*ptr),
-			   GFP_KERNEL);
-	if (!ptr)
-		return ERR_PTR(-ENOMEM);
+	struct gpio_regmap *gpio;
+	int ret;
 
 	gpio = gpio_regmap_register(config);
-	if (!IS_ERR(gpio)) {
-		*ptr = gpio;
-		devres_add(dev, ptr);
-	} else {
-		devres_free(ptr);
-	}
+
+	if (IS_ERR(gpio))
+		return gpio;
+
+	ret = devm_add_action_or_reset(dev, devm_gpio_regmap_unregister, gpio);
+	if (ret)
+		return ERR_PTR(ret);
 
 	return gpio;
 }