diff mbox series

[v3,6/6] dt-bindings: mailbox : arm,mhuv2: Use example with matching schema

Message ID 20210604205710.1944363-7-sudeep.holla@arm.com
State Accepted
Commit 0daa6056476ebe4ede2f4cce906508937193077d
Headers show
Series dt-bindings: firmware: Convert SCPI and SCMI to json schema | expand

Commit Message

Sudeep Holla June 4, 2021, 8:57 p.m. UTC
Currently the example provided in arm,mhuv2 schema complains as below:

    Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dt.yaml :0:0:
    /example-0/soc/scb@2e000000: failed to match any schema with compatible:
    ['fujitsu,mb86s70-scb-1.0']

Fix it by using an example with a matching schema that makes use of 4
mailboxes that is well suited to demonstrate Rx and Tx channels with both
doorbell and data transfer protocols.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

---
 .../bindings/mailbox/arm,mhuv2.yaml           | 25 +++++++++----------
 1 file changed, 12 insertions(+), 13 deletions(-)

-- 
2.25.1

Comments

Rob Herring (Arm) June 4, 2021, 10:26 p.m. UTC | #1
On Fri, 04 Jun 2021 21:57:10 +0100, Sudeep Holla wrote:
> Currently the example provided in arm,mhuv2 schema complains as below:

> 

>     Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dt.yaml :0:0:

>     /example-0/soc/scb@2e000000: failed to match any schema with compatible:

>     ['fujitsu,mb86s70-scb-1.0']

> 

> Fix it by using an example with a matching schema that makes use of 4

> mailboxes that is well suited to demonstrate Rx and Tx channels with both

> doorbell and data transfer protocols.

> 

> Cc: Rob Herring <robh+dt@kernel.org>

> Cc: Viresh Kumar <viresh.kumar@linaro.org>

> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

> ---

>  .../bindings/mailbox/arm,mhuv2.yaml           | 25 +++++++++----------

>  1 file changed, 12 insertions(+), 13 deletions(-)

> 


Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml
index 6608545ea66f..a4f1fe63659a 100644
--- a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml
+++ b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml
@@ -192,18 +192,17 @@  additionalProperties: false
             arm,mhuv2-protocols = <1 1>, <1 7>, <0 2>;
         };
 
-        mhu_client: scb@2e000000 {
-            compatible = "fujitsu,mb86s70-scb-1.0";
-            reg = <0 0x2e000000 0 0x4000>;
-
-            mboxes =
-                     //data-transfer protocol with 5 windows, mhu-tx
-                     <&mhu_tx 2 0>,
-                     //data-transfer protocol with 7 windows, mhu-tx
-                     <&mhu_tx 3 0>,
-                     //doorbell protocol channel 4, doorbell 27, mhu-tx
-                     <&mhu_tx 4 27>,
-                     //data-transfer protocol with 1 window, mhu-rx
-                     <&mhu_rx 0 0>;
+        mhu_client: dsp@596e8000 {
+            compatible = "fsl,imx8qxp-dsp";
+            reg = <0 0x596e8000 0 0x88000>;
+            clocks = <&adma_lpcg 0>, <&adma_lpcg 1>, <&adma_lpcg 2>;
+            clock-names = "ipg", "ocram", "core";
+            power-domains = <&pd 0>, <&pd 1>, <&pd 2>, <&pd 3>;
+            mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1";
+            mboxes = <&mhu_tx 2 0>, //data-transfer protocol with 5 windows, mhu-tx
+                     <&mhu_tx 3 0>, //data-transfer protocol with 7 windows, mhu-tx
+                     <&mhu_rx 2 27>, //doorbell protocol channel 2, doorbell 27, mhu-rx
+                     <&mhu_rx 0 0>;  //data-transfer protocol with 1 window, mhu-rx
+            memory-region = <&dsp_reserved>;
         };
     };