diff mbox series

[v13,4/7] arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM

Message ID 20210623114025.v13.4.Id45138610b749ff775186ac10b3d01c504ddf4f3@changeid
State New
Headers show
Series [v13,1/7] dt-bindings: usb: Add binding for Realtek RTS5411 hub controller | expand

Commit Message

Matthias Kaehlcke June 23, 2021, 6:41 p.m. UTC
The dependency of USB_DWC3 on USB_XHCI_PLATFORM is being changed
from 'select' to 'depends on' by another patch. The defconfig selects
USB_DWC3 and implicitly USB_DWC3_DUAL_ROLE, to keep this unchanged
USB_XHCI_PLATFORM now needs to be selected explicitly.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---

Changes in v13:
- patch added to the series

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Doug Anderson July 19, 2021, 6:07 p.m. UTC | #1
Hi,

On Mon, Jul 19, 2021 at 8:58 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>

> Will/Catalin,

>

> does this change looks good to you and could get an Acked-by?

>

> If so: would it be ok to land it through the USB tree with the

> rest of the series? It seems a conflict would be relatively

> unlikely.


Officially I don't think you really need an Ack for most changes to
this file. So says Will [1]:

> although there are a few things I really care about

> in defconfig (e.g. things like page size!), generally speaking we don't

> need to Ack everything that changes in there.


In case it helps, you can stick my Reviewed-by on there...

Reviewed-by: Douglas Anderson <dianders@chromium.org>


[1] https://lore.kernel.org/r/20201208160029.GA6461@willie-the-truck
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 08c6f769df9a..d7f22b18e37a 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -795,6 +795,7 @@  CONFIG_USB_CONN_GPIO=m
 CONFIG_USB=y
 CONFIG_USB_OTG=y
 CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_PLATFORM=y
 CONFIG_USB_XHCI_TEGRA=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_EXYNOS=y