diff mbox

[v3,3/6] usb: dwc3: dwc3-st: Update the incorrect DT dwc3 example.

Message ID 1430400652-3366-4-git-send-email-peter.griffin@linaro.org
State Superseded
Headers show

Commit Message

Peter Griffin April 30, 2015, 1:30 p.m. UTC 
There is a subtle typo phys-names should be phy-names. Using the
current example means you don't have working usb (as you fail to
obtain the phys). Also update the example to use the generic phy
type constants which are now used for miphy28.

Additionally also remove the unnecessary new line in the example.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
---
 Documentation/devicetree/bindings/usb/dwc3-st.txt | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Peter Griffin May 7, 2015, 3:13 p.m. UTC | #1 
Hi Felipe,

On Thu, 30 Apr 2015, Peter Griffin wrote:

> There is a subtle typo phys-names should be phy-names. Using the
> current example means you don't have working usb (as you fail to
> obtain the phys). Also update the example to use the generic phy
> type constants which are now used for miphy28.
> 
> Additionally also remove the unnecessary new line in the example.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

Can you take this dwc3 DT doc update patch via your tree?

regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Peter Griffin May 8, 2015, 10:31 a.m. UTC | #2 
Hi Felipe,

On Thu, 07 May 2015, Felipe Balbi wrote:

> On Thu, May 07, 2015 at 04:13:58PM +0100, Peter Griffin wrote:
> > Hi Felipe,
> > 
> > On Thu, 30 Apr 2015, Peter Griffin wrote:
> > 
> > > There is a subtle typo phys-names should be phy-names. Using the
> > > current example means you don't have working usb (as you fail to
> > > obtain the phys). Also update the example to use the generic phy
> > > type constants which are now used for miphy28.
> > > 
> > > Additionally also remove the unnecessary new line in the example.
> > > 
> > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > > Acked-by: Rob Herring <robh@kernel.org>
> > > Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
> > 
> > Can you take this dwc3 DT doc update patch via your tree?
> 
> only this patch ?

Yes, I think the test will go via Maximes STI tree

> Sure. Just post on linux-usb and I'll fetch it from
> there.

Brilliant, thanks. I've sent it see here https://lkml.org/lkml/2015/5/7/809
with linux-usb on CC (sorry for missing that off the first time round)

regards,

Peter.


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/usb/dwc3-st.txt b/Documentation/devicetree/bindings/usb/dwc3-st.txt
index f9d7025..01c71b1 100644
--- a/Documentation/devicetree/bindings/usb/dwc3-st.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3-st.txt
@@ -49,8 +49,7 @@  st_dwc3: dwc3@8f94000 {
 	st,syscfg	= <&syscfg_core>;
 	resets		= <&powerdown STIH407_USB3_POWERDOWN>,
 			  <&softreset STIH407_MIPHY2_SOFTRESET>;
-	reset-names	= "powerdown",
-			  "softreset";
+	reset-names	= "powerdown", "softreset";
 	#address-cells	= <1>;
 	#size-cells	= <1>;
 	pinctrl-names	= "default";
@@ -62,7 +61,7 @@  st_dwc3: dwc3@8f94000 {
 		reg		= <0x09900000 0x100000>;
 		interrupts	= <GIC_SPI 155 IRQ_TYPE_NONE>;
 		dr_mode		= "host";
-		phys-names      = "usb2-phy", "usb3-phy";
-		phys            = <&usb2_picophy2>, <&phy_port2 MIPHY_TYPE_USB>;
+		phy-names	= "usb2-phy", "usb3-phy";
+		phys		= <&usb2_picophy2>, <&phy_port2 PHY_TYPE_USB3>;
 	};
 };