| Message ID | 20210803072958.4815-1-o.rempel@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] dt-bindings: timer: fsl,imxgpt: add optional osc_per clock | expand |
On Tue, Aug 03, 2021 at 09:29:58AM +0200, Oleksij Rempel wrote: > Add optional osc_per and fix dts validation warnings on imx6 SoCs. > > Fixes: df8cad689eae ("dt-bindings: timer: Convert i.MX GPT to json-schema") I don't think you can say the above commit was broken. > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/timer/fsl,imxgpt.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > index a4f51f46b7a1..e496dd9f4988 100644 > --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > @@ -43,11 +43,15 @@ properties: > items: > - description: SoC GPT ipg clock > - description: SoC GPT per clock > + - description: optional SoC GPT oscillator > + minItems: 2 The 3rd clock is valid on every version of the h/w? > > clock-names: > items: > - const: ipg > - const: per > + - const: osc_per > + minItems: 2 > > required: > - compatible > @@ -70,3 +74,16 @@ examples: > <&clks IMX27_CLK_PER1_GATE>; > clock-names = "ipg", "per"; > }; > + > + - | > + #include <dt-bindings/clock/imx6qdl-clock.h> > + > + timer@2098000 { > + compatible = "fsl,imx6q-gpt", "fsl,imx31-gpt"; > + reg = <0x02098000 0x4000>; > + interrupts = <26>; > + clocks = <&clks IMX6QDL_CLK_GPT_IPG>, > + <&clks IMX6QDL_CLK_GPT_IPG_PER>, > + <&clks IMX6QDL_CLK_GPT_3M>; > + clock-names = "ipg", "per", "osc_per"; > + }; > -- > 2.30.2 > >
On Wed, Aug 11, 2021 at 12:04:38PM -0600, Rob Herring wrote: > On Tue, Aug 03, 2021 at 09:29:58AM +0200, Oleksij Rempel wrote: > > Add optional osc_per and fix dts validation warnings on imx6 SoCs. > > > > Fixes: df8cad689eae ("dt-bindings: timer: Convert i.MX GPT to json-schema") > > I don't think you can say the above commit was broken. > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > .../devicetree/bindings/timer/fsl,imxgpt.yaml | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > > index a4f51f46b7a1..e496dd9f4988 100644 > > --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > > +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > > @@ -43,11 +43,15 @@ properties: > > items: > > - description: SoC GPT ipg clock > > - description: SoC GPT per clock > > + - description: optional SoC GPT oscillator > > + minItems: 2 > > The 3rd clock is valid on every version of the h/w? No. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml index a4f51f46b7a1..e496dd9f4988 100644 --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml @@ -43,11 +43,15 @@ properties: items: - description: SoC GPT ipg clock - description: SoC GPT per clock + - description: optional SoC GPT oscillator + minItems: 2 clock-names: items: - const: ipg - const: per + - const: osc_per + minItems: 2 required: - compatible @@ -70,3 +74,16 @@ examples: <&clks IMX27_CLK_PER1_GATE>; clock-names = "ipg", "per"; }; + + - | + #include <dt-bindings/clock/imx6qdl-clock.h> + + timer@2098000 { + compatible = "fsl,imx6q-gpt", "fsl,imx31-gpt"; + reg = <0x02098000 0x4000>; + interrupts = <26>; + clocks = <&clks IMX6QDL_CLK_GPT_IPG>, + <&clks IMX6QDL_CLK_GPT_IPG_PER>, + <&clks IMX6QDL_CLK_GPT_3M>; + clock-names = "ipg", "per", "osc_per"; + };
Add optional osc_per and fix dts validation warnings on imx6 SoCs. Fixes: df8cad689eae ("dt-bindings: timer: Convert i.MX GPT to json-schema") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../devicetree/bindings/timer/fsl,imxgpt.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)